Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Commit

Permalink
fix(resolveClassNames): Handle theme dereferencing in object keys (#3)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattcompiles authored and michaeltaranto committed May 16, 2019
1 parent 8393fed commit 7957554
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/treat/src/runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const resolveClassNames = (
hasOwn.call(arg, key) &&
(arg as { [classRef: string]: boolean })[key]
) {
classes.push(key);
classes.push(getClassName(themeRef, key));
}
}
}
Expand Down
35 changes: 35 additions & 0 deletions packages/treat/tests/runtime.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
const { resolveClassNames } = require('treat');

const themeRef = '_theme';

describe('resolveClassNames', () => {
it('should handle dereference themed classes', () => {
expect(resolveClassNames(themeRef, '$someClass')).toBe('someClass_theme');
});

it('should handle regular classes', () => {
expect(resolveClassNames(themeRef, 'someClass')).toBe('someClass');
});

it('should handle arrays', () => {
const value = ['$someClass', 'someOtherClass'];

expect(resolveClassNames(themeRef, value)).toBe(
'someClass_theme someOtherClass',
);
});

it('should handle objects', () => {
const value = { ['$someClass']: true, someOtherClass: true };

expect(resolveClassNames(themeRef, value)).toBe(
'someClass_theme someOtherClass',
);
});

it('should handle objects with falsy values', () => {
const value = { $someClass: false, someOtherClass: true };

expect(resolveClassNames(themeRef, value)).toBe('someOtherClass');
});
});

0 comments on commit 7957554

Please sign in to comment.