Skip to content

Commit 52a3489

Browse files
committed
url: fix isURL detection by checking path
Fixes: nodejs/node#48921 PR-URL: nodejs/node#48928 Backport-PR-URL: nodejs/node#50105 Fixes: getsentry/sentry-javascript#8552 Fixes: request/request#3458 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
1 parent b3e3823 commit 52a3489

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

graal-nodejs/test/parallel/test-url-is-url.js

+5
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,8 @@ const { isURL } = require('internal/url');
99

1010
assert.strictEqual(isURL(new URL('https://www.nodejs.org')), true);
1111
assert.strictEqual(isURL(parse('https://www.nodejs.org')), false);
12+
assert.strictEqual(isURL({
13+
href: 'https://www.nodejs.org',
14+
protocol: 'https:',
15+
path: '/',
16+
}), false);

0 commit comments

Comments
 (0)