Skip to content

Commit 80fb5b8

Browse files
committedApr 25, 2024
bootstrap: use correct descriptor for
Followup to #48518; fixes #48699 PR-URL: nodejs/node#48703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent c8c42f8 commit 80fb5b8

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed
 

‎graal-nodejs/lib/internal/process/pre_execution.js

+19-2
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,26 @@ function prepareExecution(options) {
120120
function setupSymbolDisposePolyfill() {
121121
// TODO(MoLow): Remove this polyfill once Symbol.dispose and Symbol.asyncDispose are available in V8.
122122
// eslint-disable-next-line node-core/prefer-primordials
123-
Symbol.dispose ??= SymbolDispose;
123+
if (typeof Symbol.dispose !== 'symbol') {
124+
ObjectDefineProperty(Symbol, 'dispose', {
125+
__proto__: null,
126+
configurable: false,
127+
enumerable: false,
128+
value: SymbolDispose,
129+
writable: false,
130+
});
131+
}
132+
124133
// eslint-disable-next-line node-core/prefer-primordials
125-
Symbol.asyncDispose ??= SymbolAsyncDispose;
134+
if (typeof Symbol.asyncDispose !== 'symbol') {
135+
ObjectDefineProperty(Symbol, 'asyncDispose', {
136+
__proto__: null,
137+
configurable: false,
138+
enumerable: false,
139+
value: SymbolAsyncDispose,
140+
writable: false,
141+
});
142+
}
126143
}
127144

128145
function setupUserModules(isLoaderWorker = false) {

0 commit comments

Comments
 (0)