Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operators to configure a Build deployment via a configmap #651

Open
qu1queee opened this issue Mar 9, 2021 · 1 comment
Open

Allow operators to configure a Build deployment via a configmap #651

qu1queee opened this issue Mar 9, 2021 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Mar 9, 2021

Idea:

We currently have a list (increasing in number) on the amount of env variables one can define on the deployment definition for our controllers. There is a well known pattern for defining this key:values via an external primitive resource (e.g. configmap). AFAIK Tekton does the same.

We should consider the above. @gabemontero is this what you had in mind?

@qu1queee qu1queee added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2021
@gabemontero
Copy link
Member

hey @qu1queee yeah both for the controller as is, as well as for anything the upcoming operator might provide, abstracting out the various env vars to be set on the controllers's deployment containers seems like a good next step

and yes a configmap makes sense as the first step

if we want the operator to just manipulate the configmap, or wrapper configmap manipulation in the operator's config object, we can sort that out as @adambkaplan 's work progresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants