Skip to content

Commit bbc5216

Browse files
committed
fix lint errors
Signed-off-by: Bob Callaway <bcallaway@google.com>
1 parent 70315b3 commit bbc5216

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

cmd/api-docs/main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ func astFrom(filePath string) *doc.Package {
165165
}
166166

167167
m[filePath] = f
168-
apkg, _ := ast.NewPackage(fset, m, nil, nil) //nolint:errcheck
168+
apkg, _ := ast.NewPackage(fset, m, nil, nil) //nolint:staticcheck
169169

170170
return doc.New(apkg, "", 0)
171171
}

pkg/tuf/repo.go

+8-2
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,10 @@ func Uncompress(src io.Reader, dst string) error {
129129
}
130130
// Write out files
131131
case tar.TypeReg:
132-
fileToWrite, err := os.OpenFile(target, os.O_CREATE|os.O_RDWR, os.FileMode(header.Mode))
132+
if header.Mode < 0 && int64(uint32(header.Mode)) != header.Mode { //nolint:gosec // disable G115
133+
return errors.New("invalid mode value in tar header")
134+
}
135+
fileToWrite, err := os.OpenFile(target, os.O_CREATE|os.O_RDWR, os.FileMode(header.Mode)) //nolint:gosec // disable G115
133136
if err != nil {
134137
return err
135138
}
@@ -213,9 +216,12 @@ func UncompressMemFS(src io.Reader, stripPrefix string) (fs.FS, error) {
213216
if err != nil && err != io.EOF {
214217
return nil, fmt.Errorf("reading file %s : %w", header.Name, err)
215218
}
219+
if header.Mode < 0 && int64(uint32(header.Mode)) != header.Mode { //nolint:gosec // disable G115
220+
return nil, errors.New("invalid mode value in tar header")
221+
}
216222
testFS[target] = &fstest.MapFile{
217223
Data: data,
218-
Mode: os.FileMode(header.Mode),
224+
Mode: os.FileMode(header.Mode), //nolint:gosec // disable G115
219225
ModTime: header.ModTime,
220226
}
221227
}

pkg/webhook/validator.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ func ValidatePolicy(ctx context.Context, namespace string, ref name.Reference, c
517517
switch {
518518
case authority.Static != nil:
519519
if authority.Static.Action == "fail" {
520-
result.err = cosign.NewVerificationError("disallowed by static policy: " + authority.Static.Message)
520+
result.err = cosign.NewVerificationError("disallowed by static policy: %s", authority.Static.Message)
521521
results <- result
522522
return
523523
}

0 commit comments

Comments
 (0)