Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit dd6c3de

Browse files
committedMay 4, 2021
Have secp256k1_ge_set_gej_var initialize all fields.
Previous behaviour would not initialize r->x and r->y values in the case where infinity is passed in.
1 parent d0bd269 commit dd6c3de

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed
 

‎src/group_impl.h

+2-3
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ static void secp256k1_ge_set_gej(secp256k1_ge *r, secp256k1_gej *a) {
100100

101101
static void secp256k1_ge_set_gej_var(secp256k1_ge *r, secp256k1_gej *a) {
102102
secp256k1_fe z2, z3;
103-
r->infinity = a->infinity;
104103
if (a->infinity) {
104+
secp256k1_ge_set_infinity(r);
105105
return;
106106
}
107107
secp256k1_fe_inv_var(&a->z, &a->z);
@@ -110,8 +110,7 @@ static void secp256k1_ge_set_gej_var(secp256k1_ge *r, secp256k1_gej *a) {
110110
secp256k1_fe_mul(&a->x, &a->x, &z2);
111111
secp256k1_fe_mul(&a->y, &a->y, &z3);
112112
secp256k1_fe_set_int(&a->z, 1);
113-
r->x = a->x;
114-
r->y = a->y;
113+
secp256k1_ge_set_xy(r, &a->x, &a->y);
115114
}
116115

117116
static void secp256k1_ge_set_all_gej_var(secp256k1_ge *r, const secp256k1_gej *a, size_t len) {

0 commit comments

Comments
 (0)
Please sign in to comment.