Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MergeData test for summation #24

Open
1 task
teresi opened this issue Apr 23, 2020 · 3 comments
Open
1 task

add MergeData test for summation #24

teresi opened this issue Apr 23, 2020 · 3 comments
Assignees

Comments

@teresi
Copy link
Collaborator

teresi commented Apr 23, 2020

MergeData can calculate the sum of overlaps for superfamilies / orders but...
currently operates on fake data (real classes but with fake inputs)

MergeData currently has limited tests verifying basic functionality

  • add unit | integration test(s) to verify the values of the summation (may require faking out the overlap values manually)
@sjteresi
Copy link
Owner

sjteresi commented May 6, 2020

@teresi here are some considerations on the use of yield_fixture in test_MergeData.py

pytest yield_fixture docs
yield_fixture is deprecated. Apparently you can do the same thing inside a normal fixture and yield...

@sjteresi
Copy link
Owner

sjteresi commented May 6, 2020

To start, I am going to create a more detailed mock data for the GeneData and the TransposonData.

I have already made something like GeneData in the normalization_matrices branch, and will do something similar here for the TransposonData as well. I think that would be best to have a small subset of the annotation file that we can easily look at, wrap, and write test values for.

What do you think?

@teresi
Copy link
Collaborator Author

teresi commented Aug 20, 2020

it's been a while
but now that you have a real data subset you take the data, there, do a hand calc, and make sure it returns what you expect

as we discussed, the isntance variables superfamily order have the overlaps
there are slice functions that can help you access the data in the overlap (see left_right_slice intra_slice)

start with test_MergeData.py merge_sink_real
you need to add your real data and then make tests that make sure the summation works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants