Introduce libiconv for GDB 12+

As of GDB 12.1, libiconv is a mandatory dependency on Windows. As with
Expat, this fact is undocumented. GDB builds successfully without but
that build is broken and practically useless. This dependency introduces
no new features nor makes GDB work better (i.e. GDB still cannot display
non-ASCII strings). It is necessary only to retain the capabilities
already present in GDB 11 an earlier.

Author: skeeto

Dockerfile

@@ -9,6 +9,7 @@ ARG EXPAT_VERSION=2.5.0
 ARG GCC_VERSION=12.2.0
 ARG GDB_VERSION=11.2
 ARG GMP_VERSION=6.2.1
+ARG LIBICONV_VERSION=1.17
 ARG MAKE_VERSION=4.4
 ARG MINGW_VERSION=10.0.0
 ARG MPC_VERSION=1.2.1
@@ -32,6 +33,7 @@ RUN curl --insecure --location --remote-name-all --remote-header-name \
     https://ftp.gnu.org/gnu/mpc/mpc-$MPC_VERSION.tar.gz \
     https://ftp.gnu.org/gnu/mpfr/mpfr-$MPFR_VERSION.tar.xz \
     https://ftp.gnu.org/gnu/make/make-$MAKE_VERSION.tar.gz \
+    https://ftp.gnu.org/gnu/libiconv/libiconv-$LIBICONV_VERSION.tar.gz \
     https://frippery.org/files/busybox/busybox-w32-$BUSYBOX_VERSION.tgz \
     http://ftp.vim.org/pub/vim/unix/vim-$VIM_VERSION.tar.bz2 \
     https://www.nasm.us/pub/nasm/releasebuilds/$NASM_VERSION/nasm-$NASM_VERSION.tar.xz \
@@ -47,6 +49,7 @@ RUN sha256sum -c $PREFIX/src/SHA256SUMS \
  && tar xJf gcc-$GCC_VERSION.tar.xz \
  && tar xJf gdb-$GDB_VERSION.tar.xz \
  && tar xJf expat-$EXPAT_VERSION.tar.xz \
+ && tar xzf libiconv-$LIBICONV_VERSION.tar.gz \
  && tar xJf gmp-$GMP_VERSION.tar.xz \
  && tar xzf mpc-$MPC_VERSION.tar.gz \
  && tar xJf mpfr-$MPFR_VERSION.tar.xz \
@@ -325,12 +328,24 @@ RUN make -j$(nproc) -C wincon \
  && cp wincon/pdcurses.a /deps/lib/libcurses.a \
  && cp curses.h /deps/include
 
+WORKDIR /libiconv
+RUN /libiconv-$LIBICONV_VERSION/configure \
+        --prefix=/deps \
+        --host=$ARCH \
+        --disable-nls \
+        --disable-shared \
+        CFLAGS="-Os" \
+        LDFLAGS="-s" \
+ && make -j$(nproc) \
+ && make install
+
 WORKDIR /gdb
 RUN sed -i 's/quiet = 0/quiet = 1/' /gdb-$GDB_VERSION/gdb/main.c \
  && /gdb-$GDB_VERSION/configure \
         --host=$ARCH \
         --with-libexpat-prefix=/deps \
         --with-libgmp-prefix=/deps \
+        --with-libiconv-prefix=/deps \
         --enable-tui \
         CFLAGS="-Os -D_WIN32_WINNT=0x502 -DPDC_WIDE" \
         CXXFLAGS="-Os -DPDC_WIDE" \

src/SHA256SUMS

@@ -5,6 +5,7 @@ ef2420f0232c087801abf705e89ae65f6257df6b7931d37846a193ef2e8cdcbe  expat-2.5.0.ta
 e549cf9cf3594a00e27b6589d4322d70e0720cdd213f39beb4181e06926230ff  gcc-12.2.0.tar.xz
 1497c36a71881b8671a9a84a0ee40faab788ca30d7ba19d8463c3cc787152e32  gdb-11.2.tar.xz
 fd4829912cddd12f84181c3451cc752be224643e87fac497b69edddadc49b4f2  gmp-6.2.1.tar.xz
+8f74213b56238c85a50a5329f77e06198771e70dd9a739779f4c02f65d971313  libiconv-1.17.tar.gz
 581f4d4e872da74b3941c874215898a7d35802f03732bdccee1d4a7979105d18  make-4.4.tar.gz
 ba6b430aed72c63a3768531f6a3ffc2b0fde2c57a3b251450dcf489a894f0894  mingw-w64-v10.0.0.tar.bz2
 17503d2c395dfcf106b622dc142683c1199431d095367c6aacba6eec30340459  mpc-1.2.1.tar.gz