Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and cleannup the WIP commits #1

Closed
smortex opened this issue Sep 8, 2021 · 3 comments
Closed

Review and cleannup the WIP commits #1

smortex opened this issue Sep 8, 2021 · 3 comments
Assignees

Comments

@smortex
Copy link
Owner

smortex commented Sep 8, 2021

Can you please check the commits in the opensearch branch and tell me if you think something is wrong?

I would like to squash them as we move on

@smortex
Copy link
Owner Author

smortex commented Sep 8, 2021

Maybe I should just open a PR and ask for approval there? 🙄

@jurajlutter
Copy link
Collaborator

Yes, open a pull request.

@smortex smortex linked a pull request Sep 8, 2021 that will close this issue
@smortex
Copy link
Owner Author

smortex commented Sep 16, 2021

Review is to be done in #3. Closing

@smortex smortex closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants