.github/workflows/workflow.yml

@@ -0,0 +1,43 @@
+name: nio4r
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    name: >-
+      ${{matrix.os}}, ${{matrix.ruby}}
+    env:
+      CI: true
+      TESTOPTS: -v
+
+    runs-on: ${{matrix.os}}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-16.04, ubuntu-18.04, macos-latest, windows-latest]
+        ruby: [2.4, 2.5, 2.6, 2.7, jruby, truffleruby-head]
+        exclude:
+          - { os: windows-latest, ruby: jruby }
+          - { os: windows-latest, ruby: truffleruby-head }
+
+    steps:
+      - name: repo checkout
+        uses: actions/checkout@v2
+
+      - name: load ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{matrix.ruby}}
+
+      - name: RubyGems, Bundler Update
+        run: gem update --system --no-document --conservative
+
+      - name: bundle install
+        run: bundle install --path .bundle/gems --without development
+
+      - name: compile
+        run: bundle exec rake compile
+
+      - name: test
+        run: bundle exec rake spec
+        timeout-minutes: 10

.rubocop.yml

@@ -1,23 +1,40 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
   DisplayCopNames: true
 
+Layout/HashAlignment:
+  Enabled: false
+
+Layout/LineLength:
+  Max: 128
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: false
+
 Layout/SpaceInsideBlockBraces:
   Enabled: false
 
 Style/IfUnlessModifier:
   Enabled: false
 
+Style/UnpackFirst:
+  Enabled: false
+
 #
 # Lint
 #
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Enabled: false
 
 Lint/Loop:
   Enabled: false
 
+Lint/RaiseException:
+  Enabled: false
+
+Lint/StructNewOverride:
+  Enabled: false
 #
 # Metrics
 #
@@ -32,9 +49,6 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 128
 
-Metrics/LineLength:
-  Max: 128
-
 Metrics/MethodLength:
   CountComments: false
   Max: 50
@@ -46,16 +60,12 @@ Metrics/PerceivedComplexity:
   Max: 15
 
 #
-# Performance
+# Style
 #
 
-Performance/RegexpMatch:
+Style/ExponentialNotation:
   Enabled: false
 
-#
-# Style
-#
-
 Style/FormatStringToken:
   Enabled: false
 
@@ -65,6 +75,15 @@ Style/FrozenStringLiteralComment:
 Style/GlobalVars:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: false
+
+Style/HashTransformKeys:
+  Enabled: false
+
+Style/HashTransformValues:
+  Enabled: false
+
 Style/NumericPredicate:
   Enabled: false
 

CHANGES.md

@@ -1,3 +1,19 @@
+## 2.5.3 (2020-09-07)
+
+* [#241](https://github.com/socketry/nio4r/issues/241)
+  Possible bug with Ruby >= 2.7.0 and `GC.compact`.
+  ([@boazsegev])
+
+## 2.5.2 (2019-09-24)
+
+* [#220](https://github.com/socketry/nio4r/issues/220)
+  Update to libev-4.27 & fix assorted warnings.
+  ([@ioquatix])
+
+* [#225](https://github.com/socketry/nio4r/issues/225)
+  Avoid need for linux headers.
+  ([@ioquatix])
+
 ## 2.4.0 (2019-07-07)
 
 * [#211](https://github.com/socketry/nio4r/pull/211)
@@ -9,7 +25,7 @@
 
 * Assorted fixes for TruffleRuby & JRuby.
   ([@eregon], [@olleolleolle])
-
+Possible bug with Ruby >= 2.7.0 and `GC.compact`
 * Update libev to v4.25.
   ([@ioquatix])
 
@@ -242,3 +258,4 @@
 [@ioquatix]: https://github.com/ioquatix
 [@eregon]: https://github.com/eregon
 [@olleolleolle]: https://github.com/olleolleolle
+[@boazsegev]: https://github.com/boazsegev

Gemfile

@@ -15,5 +15,5 @@ group :development, :test do
   gem "coveralls", require: false
   gem "rake-compiler", require: false
   gem "rspec", "~> 3.7", require: false
-  gem "rubocop", "0.52.1", require: false
+  gem "rubocop", "0.82.0", require: false
 end

README.md

@@ -47,6 +47,7 @@ writing.
 * Ruby 2.4
 * Ruby 2.5
 * Ruby 2.6
+* Ruby 2.7
 * [JRuby](https://github.com/jruby/jruby)
 * [TruffleRuby](https://github.com/oracle/truffleruby)
 
@@ -120,7 +121,7 @@ rake release
 
 Released under the MIT license.
 
-Copyright, 2019, by Tony Arcieri.
+Copyright, 2019, by Tony Arcieri.  
 Copyright, 2019, by [Samuel G. D. Williams](http://www.codeotaku.com/samuel-williams).
 
 Permission is hereby granted, free of charge, to any person obtaining a copy

examples/echo_server.rb

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-$LOAD_PATH.push File.expand_path("../../lib", __FILE__)
+$LOAD_PATH.push File.expand_path("../lib", __dir__)
 require "nio"
 require "socket"
 
@@ -19,7 +19,7 @@ def initialize(host, port)
 
   def run
     loop do
-      @selector.select { |monitor| monitor.value.call(monitor) }
+      @selector.select { |monitor| monitor.value.call }
     end
   end
 

ext/libev/ev.c

@@ -335,14 +335,6 @@
 # define EV_USE_PORT 0
 #endif
 
-#ifndef EV_USE_LINUXAIO
-# if __linux /* libev currently assumes linux/aio_abi.h is always available on linux */
-#  define EV_USE_LINUXAIO 1
-# else
-#  define EV_USE_LINUXAIO 0
-# endif
-#endif
-
 #ifndef EV_USE_INOTIFY
 # if __linux && (__GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 4))
 #  define EV_USE_INOTIFY EV_FEATURE_OS
@@ -1754,7 +1746,7 @@ ev_syserr (const char *msg)
 }
 
 static void *
-ev_realloc_emul (void *ptr, long size) EV_NOEXCEPT
+ev_realloc_emul (void *ptr, size_t size) EV_NOEXCEPT
 {
   /* some systems, notably openbsd and darwin, fail to properly
    * implement realloc (x, 0) (as required by both ansi c-89 and
@@ -1770,17 +1762,17 @@ ev_realloc_emul (void *ptr, long size) EV_NOEXCEPT
   return 0;
 }
 
-static void *(*alloc)(void *ptr, long size) EV_NOEXCEPT = ev_realloc_emul;
+static void *(*alloc)(void *ptr, size_t size) EV_NOEXCEPT = ev_realloc_emul;
 
 ecb_cold
 void
-ev_set_allocator (void *(*cb)(void *ptr, long size) EV_NOEXCEPT) EV_NOEXCEPT
+ev_set_allocator (void *(*cb)(void *ptr, size_t size) EV_NOEXCEPT) EV_NOEXCEPT
 {
   alloc = cb;
 }
 
 inline_speed void *
-ev_realloc (void *ptr, long size)
+ev_realloc (void *ptr, size_t size)
 {
   ptr = alloc (ptr, size);
 
@@ -2792,7 +2784,11 @@ ev_supported_backends (void) EV_NOEXCEPT
   if (EV_USE_PORT    ) flags |= EVBACKEND_PORT;
   if (EV_USE_KQUEUE  ) flags |= EVBACKEND_KQUEUE;
   if (EV_USE_EPOLL   ) flags |= EVBACKEND_EPOLL;
+
+#ifdef EV_USE_LINUXAIO
   if (EV_USE_LINUXAIO) flags |= EVBACKEND_LINUXAIO;
+#endif
+
   if (EV_USE_POLL    ) flags |= EVBACKEND_POLL;
   if (EV_USE_SELECT  ) flags |= EVBACKEND_SELECT;
 
@@ -3636,11 +3632,13 @@ struct ev_poll_args {
 };
 
 static
-VALUE ev_backend_poll(void *ptr)
+void * ev_backend_poll(void *ptr)
 {
   struct ev_poll_args *args = (struct ev_poll_args *)ptr;
   struct ev_loop *loop = args->loop;
   backend_poll (EV_A_ args->waittime);
+
+  return NULL;
 }
 /* ######################################## */
 

ext/libev/ev.h

@@ -544,7 +544,7 @@ EV_API_DECL void ev_sleep (ev_tstamp delay) EV_NOEXCEPT; /* sleep for a while */
  * or take some potentially destructive action.
  * The default is your system realloc function.
  */
-EV_API_DECL void ev_set_allocator (void *(*cb)(void *ptr, long size) EV_NOEXCEPT) EV_NOEXCEPT;
+EV_API_DECL void ev_set_allocator (void *(*cb)(void *ptr, size_t size) EV_NOEXCEPT) EV_NOEXCEPT;
 
 /* set the callback function to call on a
  * retryable syscall error

ext/nio4r/extconf.rb

@@ -4,6 +4,7 @@
 
 # Write a dummy Makefile on Windows because we use the pure Ruby implementation there
 if Gem.win_platform?
+  require "devkit" if RUBY_PLATFORM.include?("mingw")
   File.write("Makefile", "all install::\n")
   File.write("nio4r_ext.so", "")
   exit
@@ -13,6 +14,7 @@
 
 have_header("unistd.h")
 
+$defs << "-DEV_USE_LINUXAIO"     if have_header("linux/aio_abi.h")
 $defs << "-DEV_USE_SELECT"       if have_header("sys/select.h")
 $defs << "-DEV_USE_POLL"         if have_type("port_event_t", "poll.h")
 $defs << "-DEV_USE_EPOLL"        if have_header("sys/epoll.h")

ext/nio4r/monitor.c

@@ -66,6 +66,7 @@ static VALUE NIO_Monitor_allocate(VALUE klass)
 
 static void NIO_Monitor_mark(struct NIO_Monitor *monitor)
 {
+    return rb_gc_mark(monitor->self);
 }
 
 static void NIO_Monitor_free(struct NIO_Monitor *monitor)

lib/nio/bytebuffer.rb

@@ -24,6 +24,7 @@ class ByteBuffer
     # @return [NIO::ByteBuffer]
     def initialize(capacity)
       raise TypeError, "no implicit conversion of #{capacity.class} to Integer" unless capacity.is_a?(Integer)
+
       @capacity = capacity
       clear
     end
@@ -119,9 +120,11 @@ def [](index)
     # @return [self]
     def put(str)
       raise TypeError, "expected String, got #{str.class}" unless str.respond_to?(:to_str)
+
       str = str.to_str
 
       raise OverflowError, "buffer is full" if str.length > @limit - @position
+
       @buffer[@position...str.length] = str
       @position += str.length
       self
@@ -188,6 +191,7 @@ def mark
     # @raise [NIO::ByteBuffer::MarkUnsetError] mark has not been set (call `#mark` first)
     def reset
       raise MarkUnsetError, "mark has not been set" unless @mark
+
       @position = @mark
       self
     end

lib/nio/monitor.rb

@@ -8,7 +8,7 @@ class Monitor
 
     # :nodoc:
     def initialize(io, interests, selector)
-      unless io.is_a? OpenSSL::SSL::SSLSocket
+      unless defined?(::OpenSSL) && io.is_a?(::OpenSSL::SSL::SSLSocket)
         unless io.is_a?(IO)
           if IO.respond_to? :try_convert
             io = IO.try_convert(io)

lib/nio/selector.rb

@@ -44,7 +44,7 @@ def backend
     # * :w - is the IO writeable?
     # * :rw - is the IO either readable or writeable?
     def register(io, interest)
-      unless io.is_a? OpenSSL::SSL::SSLSocket
+      unless defined?(::OpenSSL) && io.is_a?(::OpenSSL::SSL::SSLSocket)
         io = IO.try_convert(io)
       end
 

lib/nio/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NIO
-  VERSION = "2.5.1"
+  VERSION = "2.5.3"
 end

nio4r.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require File.expand_path("../lib/nio/version", __FILE__)
+require File.expand_path("lib/nio/version", __dir__)
 
 Gem::Specification.new do |spec|
   spec.authors       = ["Tony Arcieri"]
@@ -20,7 +20,15 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.version       = NIO::VERSION
 
-  spec.required_ruby_version = ">= 2.3"
+  spec.metadata = {
+    "bug_tracker_uri"   => "https://github.com/socketry/nio4r/issues",
+    "changelog_uri"     => "https://github.com/socketry/nio4r/blob/master/CHANGES.md",
+    "documentation_uri" => "https://www.rubydoc.info/gems/nio4r/#{spec.version}",
+    "source_code_uri"   => "https://github.com/socketry/nio4r/tree/v#{spec.version}",
+    "wiki_uri"          => "https://github.com/socketry/nio4r/wiki"
+  }
+
+  spec.required_ruby_version = ">= 2.4"
 
   if defined? JRUBY_VERSION
     spec.files << "lib/nio4r_ext.jar"

spec/nio/bytebuffer_spec.rb

@@ -352,4 +352,3 @@
     end
   end
 end
-# rubocop:enable Metrics/BlockLength

spec/nio/selectables/ssl_socket_spec.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
 require "spec_helper"
-require "openssl"
 
 RSpec.describe OpenSSL::SSL::SSLSocket do
+
+  require "openssl"
+
   before(:all) do
     @tls = []
   end

spec/nio/selectables/udp_socket_spec.rb

@@ -33,8 +33,8 @@
       peer.send("X" * 1024, 0)
       cntr += 1
       t = select [], [peer], [], 0
-    rescue Errno::ECONNREFUSED => ex
-      skip "Couldn't make writable UDPSocket subject: #{ex.class}: #{ex}"
+    rescue Errno::ECONNREFUSED => e
+      skip "Couldn't make writable UDPSocket subject: #{e.class}: #{e}"
     end while t && t[1].include?(peer) && cntr < 5
 
     peer

spec/nio/selector_spec.rb

@@ -234,4 +234,3 @@
     expect(subject).to be_closed
   end
 end
-# rubocop:enable Metrics/BlockLength