Skip to content

Commit 914b236

Browse files
authored
DevKit updates (#1674)
1 parent d36f309 commit 914b236

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Closes #{put_issue_number_here}.
2323

2424
<!-- MANDATORY
2525
Fill the changelog part inside the code block.
26-
Follow this schema: http://keepachangelog.com/
26+
Follow this schema: https://keepachangelog.com/
2727
This will end up on https://github.com/sonata-project/SonataPageBundle/releases,
2828
please keep it short and clear and to the point
2929
-->
@@ -34,10 +34,13 @@ Closes #{put_issue_number_here}.
3434
(eg. update to docs, tests)
3535
-->
3636

37-
<!-- REMOVE EMPTY SECTIONS -->
37+
<!-- REMOVE EMPTY SECTIONS
38+
- Don't repeat the verb in the messages (don't use "Added", "Changed", etc).
39+
- Don't use a full stop at the end of the messages.
40+
-->
3841
```markdown
3942
### Added
40-
- Added some `Class::newMethod()` to do great stuff.
43+
- Some `Class::newMethod()` to do great stuff
4144

4245
### Changed
4346

CONTRIBUTING.md

+8-8
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ you using the latest patch version?
3636

3737
GitHub Issues is for **issues**, as opposed to question on how to use Sonata.
3838
If you are not sure this is a bug, or simply want to ask such a question,
39-
please post your question on [Stack Overflow](http://stackoverflow.com/questions/tagged/sonata),
39+
please post your question on [Stack Overflow](https://stackoverflow.com/questions/tagged/sonata),
4040
using the `sonata` tags.
4141

4242
If you happen to find a bug, we kindly request you report it. However,
@@ -80,11 +80,11 @@ But please, read the following before.
8080

8181
#### Coding style
8282

83-
Each project follows [PSR-1](http://www.php-fig.org/psr/psr-1/), [PSR-2](http://www.php-fig.org/psr/psr-2/)
84-
and [Symfony Coding Standards](http://symfony.com/doc/current/contributing/code/standards.html) for coding style,
85-
[PSR-4](http://www.php-fig.org/psr/psr-4/) for autoloading.
83+
Each project follows [PSR-1](https://www.php-fig.org/psr/psr-1/), [PSR-2](https://www.php-fig.org/psr/psr-2/)
84+
and [Symfony Coding Standards](https://symfony.com/doc/current/contributing/code/standards.html) for coding style,
85+
[PSR-4](https://www.php-fig.org/psr/psr-4/) for autoloading.
8686

87-
Please [install PHP Coding Standard Fixer](http://cs.sensiolabs.org/#installation)
87+
Please [install PHP Coding Standard Fixer](https://cs.symfony.com/#installation)
8888
and run this command before committing your modifications:
8989

9090
```bash
@@ -271,13 +271,13 @@ Your note can be put on one of these sections:
271271
* `Fixed` for any bug fixes.
272272
* `Security` to invite users to upgrade in case of vulnerabilities.
273273

274-
More information about the followed changelog format: [keepachangelog.com](http://keepachangelog.com/)
274+
More information about the followed changelog format: [keepachangelog.com](https://keepachangelog.com/)
275275

276276
#### Base branch
277277

278278
Before writing a PR, you have to check on which branch your changes SHOULD be based.
279279

280-
Each project follows [semver](http://semver.org/) convention for release management.
280+
Each project follows [semver](https://semver.org/) convention for release management.
281281

282282
Here is a short table resuming on which you have to start:
283283

@@ -393,7 +393,7 @@ If the deprecated thing is a service, you **MUST** specify it on the service def
393393
</service>
394394
```
395395

396-
More info: http://symfony.com/blog/new-in-symfony-2-8-deprecated-service-definitions
396+
More info: https://symfony.com/blog/new-in-symfony-2-8-deprecated-service-definitions
397397

398398
For everything else, not managed by the `@deprecated` tag,
399399
you **MUST** still trigger a deprecation message (and add a `NEXT_MAJOR` comment).

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Check out the documentation on the [official website](https://docs.sonata-projec
2828

2929
## Support
3030

31-
For general support and questions, please use [StackOverflow](http://stackoverflow.com/questions/tagged/sonata).
31+
For general support and questions, please use [StackOverflow](https://stackoverflow.com/questions/tagged/sonata).
3232

3333
If you think you found a bug or you have a feature idea to propose, feel free to open an issue
3434
**after looking** at the [contributing guide](CONTRIBUTING.md).

0 commit comments

Comments
 (0)