Skip to content

Commit b73f9a7

Browse files
phansysjordisala1991
authored andcommitted
Fix API route names
1 parent 11e83c3 commit b73f9a7

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

src/Controller/Api/GroupController.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public function __construct(GroupManagerInterface $groupManager, FormFactoryInte
6464
* output={"class"="Sonata\DatagridBundle\Pager\PagerInterface", "groups"={"sonata_api_read"}}
6565
* )
6666
*
67-
* @Get("/groups")
67+
* @Get("/groups", name="get_groups")
6868
*
6969
* @QueryParam(name="page", requirements="\d+", default="1", description="Page for groups list pagination (1-indexed)")
7070
* @QueryParam(name="count", requirements="\d+", default="10", description="Number of groups by page")
@@ -115,7 +115,7 @@ public function getGroupsAction(ParamFetcherInterface $paramFetcher)
115115
* }
116116
* )
117117
*
118-
* @Get("/group/{id}")
118+
* @Get("/group/{id}", name="get_group")
119119
*
120120
* @View(serializerGroups={"sonata_api_read"}, serializerEnableMaxDepthChecks=true)
121121
*
@@ -140,7 +140,7 @@ public function getGroupAction($id)
140140
* }
141141
* )
142142
*
143-
* @Post("/group")
143+
* @Post("/group", name="post_group")
144144
*
145145
* @param Request $request A Symfony request
146146
*
@@ -169,7 +169,7 @@ public function postGroupAction(Request $request)
169169
* }
170170
* )
171171
*
172-
* @Put("/group/{id}")
172+
* @Put("/group/{id}", name="put_group")
173173
*
174174
* @param int $id Group identifier
175175
* @param Request $request A Symfony request
@@ -197,7 +197,7 @@ public function putGroupAction($id, Request $request)
197197
* }
198198
* )
199199
*
200-
* @Delete("/group/{id}")
200+
* @Delete("/group/{id}", name="delete_group")
201201
*
202202
* @param int $id A Group identifier
203203
*

src/Controller/Api/UserController.php

+7-7
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public function __construct(UserManagerInterface $userManager, GroupManagerInter
6868
* output={"class"="Sonata\DatagridBundle\Pager\PagerInterface", "groups"={"sonata_api_read"}}
6969
* )
7070
*
71-
* @Get("/users")
71+
* @Get("/users", name="get_users")
7272
*
7373
* @QueryParam(name="page", requirements="\d+", default="1", description="Page for users list pagination (1-indexed)")
7474
* @QueryParam(name="count", requirements="\d+", default="10", description="Number of users by page")
@@ -119,7 +119,7 @@ public function getUsersAction(ParamFetcherInterface $paramFetcher)
119119
* }
120120
* )
121121
*
122-
* @Get("/user/(id}")
122+
* @Get("/user/(id}", name="get_user")
123123
*
124124
* @View(serializerGroups={"sonata_api_read"}, serializerEnableMaxDepthChecks=true)
125125
*
@@ -144,7 +144,7 @@ public function getUserAction($id)
144144
* }
145145
* )
146146
*
147-
* @Post("/user")
147+
* @Post("/user", name="post_user")
148148
*
149149
* @param Request $request A Symfony request
150150
*
@@ -173,7 +173,7 @@ public function postUserAction(Request $request)
173173
* }
174174
* )
175175
*
176-
* @Put("/user/(id}")
176+
* @Put("/user/(id}", name="put_user")
177177
*
178178
* @param int $id User id
179179
* @param Request $request A Symfony request
@@ -201,7 +201,7 @@ public function putUserAction($id, Request $request)
201201
* }
202202
* )
203203
*
204-
* @Delete("/user/(id}")
204+
* @Delete("/user/(id}", name="delete_user")
205205
*
206206
* @param int $id An User identifier
207207
*
@@ -234,7 +234,7 @@ public function deleteUserAction($id)
234234
* }
235235
* )
236236
*
237-
* @Post("/user/(userId}/{groupId}")
237+
* @Post("/user/(userId}/{groupId}", name="post_user_group")
238238
*
239239
* @param int $userId A User identifier
240240
* @param int $groupId A Group identifier
@@ -277,7 +277,7 @@ public function postUserGroupAction($userId, $groupId)
277277
* }
278278
* )
279279
*
280-
* @Delete("/user/(userId}/{groupId}")
280+
* @Delete("/user/(userId}/{groupId}", name="delete_user_group")
281281
*
282282
* @param int $userId A User identifier
283283
* @param int $groupId A Group identifier

tests/Functional/Routing/RoutingTest.php

+12-12
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,18 @@ public function testRoutes(string $name, string $path, array $methods): void
4141
public function getRoutes(): iterable
4242
{
4343
yield ['nelmio_api_doc_index', '/api/doc/{view}', ['GET']];
44-
yield ['sonata_api_user_user_sonata_user_api_user_getusers', '/api/user/users', ['GET']];
45-
yield ['sonata_api_user_user_sonata_user_api_user_getuser', '/api/user/user/(id}', ['GET']];
46-
yield ['sonata_api_user_user_sonata_user_api_user_postuser', '/api/user/user', ['POST']];
47-
yield ['sonata_api_user_user_sonata_user_api_user_putuser', '/api/user/user/(id}', ['PUT']];
48-
yield ['sonata_api_user_user_sonata_user_api_user_deleteuser', '/api/user/user/(id}', ['DELETE']];
49-
yield ['sonata_api_user_user_sonata_user_api_user_postusergroup', '/api/user/user/(userId}/{groupId}', ['POST']];
50-
yield ['sonata_api_user_user_sonata_user_api_user_deleteusergroup', '/api/user/user/(userId}/{groupId}', ['DELETE']];
51-
yield ['sonata_api_user_group_sonata_user_api_group_getgroups', '/api/user/groups', ['GET']];
52-
yield ['sonata_api_user_group_sonata_user_api_group_getgroup', '/api/user/group/{id}', ['GET']];
53-
yield ['sonata_api_user_group_sonata_user_api_group_postgroup', '/api/user/group', ['POST']];
54-
yield ['sonata_api_user_group_sonata_user_api_group_putgroup', '/api/user/group/{id}', ['PUT']];
55-
yield ['sonata_api_user_group_sonata_user_api_group_deletegroup', '/api/user/group/{id}', ['DELETE']];
44+
yield ['sonata_api_user_user_get_users', '/api/user/users', ['GET']];
45+
yield ['sonata_api_user_user_get_user', '/api/user/user/(id}', ['GET']];
46+
yield ['sonata_api_user_user_post_user', '/api/user/user', ['POST']];
47+
yield ['sonata_api_user_user_put_user', '/api/user/user/(id}', ['PUT']];
48+
yield ['sonata_api_user_user_delete_user', '/api/user/user/(id}', ['DELETE']];
49+
yield ['sonata_api_user_user_post_user_group', '/api/user/user/(userId}/{groupId}', ['POST']];
50+
yield ['sonata_api_user_user_delete_user_group', '/api/user/user/(userId}/{groupId}', ['DELETE']];
51+
yield ['sonata_api_user_group_get_groups', '/api/user/groups', ['GET']];
52+
yield ['sonata_api_user_group_get_group', '/api/user/group/{id}', ['GET']];
53+
yield ['sonata_api_user_group_post_group', '/api/user/group', ['POST']];
54+
yield ['sonata_api_user_group_put_group', '/api/user/group/{id}', ['PUT']];
55+
yield ['sonata_api_user_group_delete_group', '/api/user/group/{id}', ['DELETE']];
5656
}
5757

5858
protected static function getKernelClass(): string

0 commit comments

Comments
 (0)