Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression between 2.2 and 2.3 #2278

Closed
tchoutri opened this issue May 28, 2022 · 3 comments
Closed

Regression between 2.2 and 2.3 #2278

tchoutri opened this issue May 28, 2022 · 3 comments

Comments

@tchoutri
Copy link

tchoutri commented May 28, 2022

I have a datalog file (joined) that used to compile well, but now produces CPP code that makes g++ unhappy:

cbits/categorise.cpp:344:1: error:
     error: ‘SymbolTableImpl’ does not name a type; did you mean ‘SymbolTable’?
      344 | SymbolTableImpl symTable{
          | ^~~~~~~~~~~~~~~
          | SymbolTable
    |
344 | SymbolTableImpl symTable{
    | ^
[…]

log.txt

categorise.dl

edit: @luc-tielen is investigating, since I'm using his Haskell bindings.

@luc-tielen
Copy link
Contributor

luc-tielen commented May 29, 2022

Did some initial investigations. It's due to changing header files (which I have to manually update in souffle-haskell each time).

I tried upgrading everything to souffle 2.3, but now I'm getting a segfault in the C++ code. Most likely this is due to my small "C++ interop layer" that needs to be updated..

I posted the gdb backtrace in the PR where I am doing the upgrade: luc-tielen/souffle-haskell#65.

I did see that support for serializing ADTs etc was added, maybe that broke something? (Even though I don't use them?)

@b-scholz
Copy link
Member

Could it be that you mix headers of different versions of souffle?

@luc-tielen
Copy link
Contributor

@b-scholz Yes, but I did update them in my library after @tchoutri pointed it out to me.

Then I ran into the segfault I mentioned earlier, but that might actually have been due to my laptop not being correctly setup.

I took another look at it today, and it seems like it is building fine on Ubuntu, but for OSX I still run into an issue building souffle itself. I made PR #2279 for this.

In the meantime I think this issue can be closed, and we can follow up the OSX issue in the other PR.

@b-scholz b-scholz closed this as completed Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants