Use builderReadyCondition.IsTrue() to check readiness

Previously we used `builderReadyCondition.IsFalse()` to check whether
the builder is ready. However, `IsFalse` returns `false` when the
condition is `nil` which is not what we want - when the ready condition
is `nil` we should consider that the builder is not ready.

Instead, we now use `builderReadyCondition.IsTrue()` which only returns
`true` if the ready condition is set, and its status is `True`.

We also change the way we check for builder ready timeout - we base the
check on the build workload creation time instead of the builder ready
status condition transition time as the condition itself might be nil.

Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>

Author: danail-branekov

kpack-image-builder/controllers/buildworkload_controller.go

@@ -209,8 +209,8 @@ func (r *BuildWorkloadReconciler) ReconcileResource(ctx context.Context, buildWo
 		return ctrl.Result{}, ignoreDoNotRetryError(fmt.Errorf("failed getting builder readiness condition"))
 	}
 
-	if builderReadyCondition.IsFalse() {
-		if time.Since(builderReadyCondition.LastTransitionTime.Inner.Time) < r.builderReadinessTimeout {
+	if !builderReadyCondition.IsTrue() {
+		if time.Since(buildWorkload.CreationTimestamp.Time) < r.builderReadinessTimeout {
 			log.Info("waiting for builder to be ready")
 			return ctrl.Result{RequeueAfter: time.Second}, nil
 		}

kpack-image-builder/controllers/buildworkload_controller_test.go

@@ -815,6 +815,50 @@ var _ = Describe("BuildWorkloadReconciler", func() {
 		})
 	})
 
+	When("the cluster builder readiness is not set", func() {
+		BeforeEach(func() {
+			Expect(k8s.Patch(ctx, adminClient, clusterBuilder, func() {
+				clusterBuilder.Status.Conditions = corev1alpha1.Conditions{}
+			})).To(Succeed())
+
+			buildWorkload = buildWorkloadObject(buildWorkloadGUID, namespaceGUID, source, env, services, reconcilerName, buildpacks)
+			Expect(adminClient.Create(ctx, buildWorkload)).To(Succeed())
+		})
+
+		It("sets the Succeeded condition to False", func() {
+			Eventually(func(g Gomega) {
+				g.Expect(adminClient.Get(ctx, client.ObjectKeyFromObject(buildWorkload), buildWorkload)).To(Succeed())
+				g.Expect(mustHaveCondition(g, buildWorkload.Status.Conditions, "Succeeded").Status).To(Equal(metav1.ConditionFalse))
+				g.Expect(mustHaveCondition(g, buildWorkload.Status.Conditions, "Succeeded").Reason).To(Equal("BuilderNotReady"))
+			}).Should(Succeed())
+		})
+	})
+
+	When("the cluster builder readiness is unknown", func() {
+		BeforeEach(func() {
+			Expect(k8s.Patch(ctx, adminClient, clusterBuilder, func() {
+				clusterBuilder.Status.Conditions = corev1alpha1.Conditions{
+					{
+						Type:               corev1alpha1.ConditionType("Ready"),
+						Status:             corev1.ConditionStatus(metav1.ConditionUnknown),
+						LastTransitionTime: corev1alpha1.VolatileTime{Inner: metav1.Now()},
+					},
+				}
+			})).To(Succeed())
+
+			buildWorkload = buildWorkloadObject(buildWorkloadGUID, namespaceGUID, source, env, services, reconcilerName, buildpacks)
+			Expect(adminClient.Create(ctx, buildWorkload)).To(Succeed())
+		})
+
+		It("sets the Succeeded condition to False", func() {
+			Eventually(func(g Gomega) {
+				g.Expect(adminClient.Get(ctx, client.ObjectKeyFromObject(buildWorkload), buildWorkload)).To(Succeed())
+				g.Expect(mustHaveCondition(g, buildWorkload.Status.Conditions, "Succeeded").Status).To(Equal(metav1.ConditionFalse))
+				g.Expect(mustHaveCondition(g, buildWorkload.Status.Conditions, "Succeeded").Reason).To(Equal("BuilderNotReady"))
+			}).Should(Succeed())
+		})
+	})
+
 	When("multiple BuildWorkloads exist for the same app", func() {
 		var buildWorkload2 *korifiv1alpha1.BuildWorkload