Skip to content

Commit e9c76b8

Browse files
authored
Merge pull request #378 from ashmaroli/flat-map
Prefer Enumerable#flat_map over .map.flatten chain
2 parents c1fed1c + 6db5ebf commit e9c76b8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/addressable/template.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -657,12 +657,12 @@ def named_captures
657657
def ordered_variable_defaults
658658
@ordered_variable_defaults ||= begin
659659
expansions, _ = parse_template_pattern(pattern)
660-
expansions.map do |capture|
660+
expansions.flat_map do |capture|
661661
_, _, varlist = *capture.match(EXPRESSION)
662662
varlist.split(',').map do |varspec|
663663
varspec[VARSPEC, 1]
664664
end
665-
end.flatten
665+
end
666666
end
667667
end
668668

lib/addressable/uri.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -561,10 +561,10 @@ def self.normalize_component(component, character_class=
561561
leave_re = if leave_encoded.length > 0
562562
character_class = "#{character_class}%" unless character_class.include?('%')
563563

564-
"|%(?!#{leave_encoded.chars.map do |char|
564+
"|%(?!#{leave_encoded.chars.flat_map do |char|
565565
seq = SEQUENCE_ENCODING_TABLE[char]
566566
[seq.upcase, seq.downcase]
567-
end.flatten.join('|')})"
567+
end.join('|')})"
568568
end
569569

570570
character_class = if leave_re

0 commit comments

Comments
 (0)