Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut annotations @QueryMapping, @MutationMapping, and @SubscriptionMapping should target ElementType.METHOD only #290

Closed
rstoyanchev opened this issue Feb 16, 2022 · 1 comment
Assignees
Labels
type: bug A general bug
Milestone

Comments

@rstoyanchev
Copy link
Contributor

The Javadoc says you can use these both at the method and at the class level, in which case all handlers methods in the controllers inherit that type name, but that's pointless currently since a method still needs to be annotated, e.g. with the shortcut annotation, so that doesn't save anything.

@rstoyanchev
Copy link
Contributor Author

rstoyanchev commented Feb 16, 2022

It looks like this came from #195 but I think that should be covered by a class-level @SchemaMapping. I can't see a good reason for shortcut annotations on the class level as you would still need to annotate individual handler methods and for that the shortcut provides the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant