Auto-registration of @GraphQlRepository does not work for output type defined as non-null

[NavidMitchell]

First off, I want to say Thank you! for building Spring GraphQL I like the project and where it is headed! :)

If you take a look at the spring-graphql/samples/webmvc-http and you take the schema for the query defined as.

type Query {
    artifactRepositories : [ArtifactRepository]
}

And you change this to

type Query {
    artifactRepositories : [ArtifactRepository!]
}

The query will no longer return any results since the data fetcher will not be found anymore.

This appears to be a problem in org.springframework.graphql.data.query.AutoRegistrationRuntimeWiringConfigurer Line 87 is not unwrapping NotNull types.

GraphQLType outputType = (environment.getFieldType() instanceof GraphQLList ?
		((GraphQLList) environment.getFieldType()).getWrappedType() :
		environment.getFieldType());

Unless this was the desired result. If that is the case It would be nice to update the docs with a warning. I chased my tail for a while because I could not get any results. Since I had defined my queries with non null result types. Which I think is semantically correct for spring data.

[bclozel]

We might have to unwrap graphql.language.NonNullType

[NavidMitchell]

@bclozel if you want I can submit a PR ?

[rstoyanchev]

Sure, if you've identified the fix already, and adding a test as well would be great.

[NavidMitchell]

Ok I will do this over the weekend.

[rstoyanchev]

Should be fixed now.