fix: silent exit on unsupported node.js versions (#1829)

Author: voxpelli

.github/workflows/old-test.yml

@@ -19,7 +19,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [0.10.48]
+        node-version: [0.10.48, 4]
 
     steps:
       - name: Checkout project
@@ -30,17 +30,9 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      - name: Cache Node dependencies
-        uses: actions/cache@v3
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package.json') }}
-          restore-keys: |
-            ${{ runner.os }}-node-
-
       - name: Install dependencies
-        run: npm install
+        run: npm install --production
 
       - name: Test that the command line program exits cleanly.
-        run: ./bin/cmd.js
+        run: ./bin/cmd.cjs
         shell: bash

bin/cmd.cjs

@@ -0,0 +1,3 @@
+#!/usr/bin/env node
+
+require('version-guard')('../lib/cli.js', 12, 22)

bin/cmd.js

@@ -1,5 +1,5 @@
 /*! standard. MIT License. Feross Aboukhadijeh <https://feross.org/opensource> */
 import { StandardEngine } from 'standard-engine'
-import options from './options.js'
+import options from './lib/options.js'
 
 export default new StandardEngine(options)

index.js

@@ -0,0 +1,4 @@
+import { cli } from 'standard-engine'
+import options from './options.js'
+
+cli(options)

lib/cli.js

@@ -3,8 +3,8 @@ import { fileURLToPath } from 'node:url'
 import eslint from 'eslint'
 
 // eslintConfig.overrideConfigFile have problem reading URLs and file:///
-const overrideConfigFile = fileURLToPath(new URL('./eslintrc.json', import.meta.url))
-const pkgURL = new URL('./package.json', import.meta.url)
+const overrideConfigFile = fileURLToPath(new URL('../eslintrc.json', import.meta.url))
+const pkgURL = new URL('../package.json', import.meta.url)
 const pkgJSON = readFileSync(pkgURL, { encoding: 'utf-8' })
 const pkg = JSON.parse(pkgJSON)
 

options.js lib/options.js

@@ -8,7 +8,7 @@
     "url": "https://feross.org"
   },
   "bin": {
-    "standard": "bin/cmd.js"
+    "standard": "bin/cmd.cjs"
   },
   "type": "module",
   "bugs": {
@@ -22,7 +22,8 @@
     "eslint-plugin-n": "^15.1.0",
     "eslint-plugin-promise": "^6.0.0",
     "eslint-plugin-react": "^7.28.0",
-    "standard-engine": "^15.0.0"
+    "standard-engine": "^15.0.0",
+    "version-guard": "^1.1.0"
   },
   "devDependencies": {
     "cross-spawn": "^7.0.3",
@@ -70,7 +71,7 @@
   },
   "scripts": {
     "test": "npm run test-internal && npm run test-external",
-    "test-internal": "./bin/cmd.js --verbose && tape test/*.js",
+    "test-internal": "./bin/cmd.cjs --verbose && tape test/*.js",
     "test-external": "tape test/external/*.js",
     "update-authors": "./tools/update-authors.sh && hallmark --fix AUTHORS.md"
   },

package.json

@@ -3,7 +3,7 @@ import standard from '../index.js'
 
 test('api: lintFiles', async (t) => {
   t.plan(2)
-  const [result] = await standard.lintFiles(['bin/cmd.js'])
+  const [result] = await standard.lintFiles(['bin/cmd.cjs'])
   t.equal(typeof result, 'object', 'result is an object')
   t.equal(result.errorCount, 0)
 })

test/api.js

@@ -2,7 +2,7 @@ import { fileURLToPath } from 'node:url'
 import test from 'tape'
 import crossSpawn from 'cross-spawn'
 
-const CMD_PATH = fileURLToPath(new URL('../bin/cmd.js', import.meta.url))
+const CMD_PATH = fileURLToPath(new URL('../bin/cmd.cjs', import.meta.url))
 
 test('command line usage: --help', t => {
   t.plan(1)

test/cmd.js

@@ -20,7 +20,7 @@ const testPkgs = JSON.parse(json)
 
 const GIT = 'git'
 const NPM = 'npm'
-const STANDARD = fileURLToPath(new URL('../../bin/cmd.js', import.meta.url))
+const STANDARD = fileURLToPath(new URL('../../bin/cmd.cjs', import.meta.url))
 const TMP = new URL('../../tmp/', import.meta.url)
 const PARALLEL_LIMIT = Math.ceil(cpus().length / 2)