-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ENS support #669
Comments
Great idea something we've been thinking about for sure, we'll certainly enable ENS for the !browse command when we deliver Swarm support, for username maybe something similar would work, not sure if an auction for name registration is super ideal? What are your thoughts? |
No need for an auction - you could register 'mystatus.eth', and set up your own first-in-first-served registrar that lets people instantly register 'myname.mystatus.eth' and point it at their newly generated wallet. |
if you wanna get really crazy you can also register 'xn--os8h.eth' which is 💬.eth so I can then be 🐰.💬.eth and emoji shortcut my way in 😅 |
@Arachnid of course! I'm not sure why I didn't think of that, we were thinking of doing exactly this for an unannounced feature, Moments, using Swarm. @rabbit that is actually super cool, I'm going to register it today! One thing we're trying to figure out, is what is going to be the |
I'd recommend |
Followed http://docs.ens.domains/en/latest/auctions.html and have setup 2 auctions 👍 |
I'm afraid ENS stores unicode directly, instead of using Punycode - so you can register that, but nothing ought to resolve to it. |
but the punycode version passes the 7 character limit hurdle, and we can clean it up in the frontend, of course this creates a problem if a single unicode char could be registered |
If you do that, though, you won't be compliant with the spec, and your users will get different results for domains that contain unicode characters compared to users on other platforms. |
yeah :) I understood that before posting, my point was, it's easier for us to implement punycode on the client and have a fun name in ENS than to have what we want. I'm really looking forward to a more effective solution against the first mover advantage than imposing an arbitrary limit on the amount of characters (what about the other 34% >7 words in googles english top 10000 word frequency list), my understanding the current plan is to deploy the current implementation to Specs aside, we are talking about branding, and making pretty, accessible names resolving to ugly objects. It was hard enough to get I'm very excited to use ENS as |
I obviously meant this as a one off silly suggestion but I don't understand, @Arachnid a browser would be doing the conversion prior to any request, no? storing unicode domain names sounds like a supremely exploitable problem. I thought that was the point of punycode. |
situation is worse than I thought seems to be a series of contextual rules? not great... |
That's right. We're acknowledging that we can't build a perfect system first off, so we want to get things off the ground with a simple system that works, and give people time to propose better long-term solutions. It's even possible we'll reduce the minimum length before the switchover, but it'll certainly start out at 7 characters. Unless you can propose a way to hand these out fairly when the system is still in its infancy. ;)
The point of punycode is to support Unicode domain names in a system that only reliably transports 7-bit ASCII. ENS doesn't have this issue, so it encodes Unicode directly instead. Resolvers shouldn't do punycode encoding before doing lookups for this reason. Nameprep normalises equivalent names (case folding, etc), while browsers or registrars are expected to prohibit homoglyphs in names. Because doing this is so complex, and because the onchain system works with hashes, we're punting the latter to browsers. Fortunately, this seems relatively well established; see Mozilla's algorithm for example. |
Hmm, okay, but that these algorithms revert to displaying punycode otherwise, so we'd be implementing it anyway, meaning that For reference here is how Chrome handles it. |
Good point; perhaps some other alternative would make more sense here, like highlighting the problematic characters? |
my head has exploded enough over this. character encodings and time are the bane of our existence. I defer to others. |
Just registered
|
+1 |
As @jeluard mentioned we are actively workign on ENS resolution support in chat and wallet, as well as ENS registration. I'll close this in favour of the more granular issues. |
With ENS support, you could allow users to choose easily memorable names that are associated with their public key or hash.
The text was updated successfully, but these errors were encountered: