Skip to content

Commit acc279e

Browse files
authored
ACM-10019 - 3.update searchSchema with managedHub (#219)
Signed-off-by: Sherin Varughese <shvarugh@redhat.com>
1 parent e7ed55c commit acc279e

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

pkg/federated/federated_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func TestGetFederatedResponseSuccess(t *testing.T) {
221221
assert.Equal(t, 1, len(fedRequest.Response.Data.Search))
222222
assert.Equal(t, 2, fedRequest.Response.Data.Search[0].Count)
223223
assert.Equal(t, 2, len(fedRequest.Response.Data.SearchComplete))
224-
assert.Equal(t, 3, len(fedRequest.Response.Data.SearchSchema.AllProperties))
224+
assert.Equal(t, 4, len(fedRequest.Response.Data.SearchSchema.AllProperties)) //managedHub is added after merge
225225

226226
}
227227

pkg/federated/mergeResponses.go

+2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ func (d *Data) mergeSearchSchema(schemaProps []string) {
1111
if d.SearchSchema == nil {
1212
d.searchSchemaValues = make(map[string]interface{})
1313
d.SearchSchema = &SearchSchema{AllProperties: make([]string, 0)}
14+
// Add "managedHub" as a filter option in global Search - ACM-10019
15+
schemaProps = append([]string{"managedHub"}, schemaProps[:]...)
1416
}
1517
for _, prop := range schemaProps {
1618
if _, exists := d.searchSchemaValues[prop]; !exists {

pkg/federated/mergeResponses_test.go

+10
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ package federated
44
import (
55
"reflect"
66
"testing"
7+
8+
"github.com/stolostron/search-v2-api/pkg/resolver"
9+
"github.com/stretchr/testify/assert"
710
)
811

912
func TestAppendRelatedResults(t *testing.T) {
@@ -30,3 +33,10 @@ func TestAppendRelatedResults(t *testing.T) {
3033
t.Errorf("Unexpected result. Expected: %v, Got: %v", expected, result)
3134
}
3235
}
36+
37+
func Test_mergeSearchSchema(t *testing.T) {
38+
d := &Data{}
39+
d.mergeSearchSchema([]string{"kind", "cluster"})
40+
shouldbeTrue := resolver.CheckIfInArray(d.SearchSchema.AllProperties, "managedHub")
41+
assert.True(t, shouldbeTrue, true, "Expected managedHub to be present in the schema. Expected true, got %t", shouldbeTrue)
42+
}

0 commit comments

Comments
 (0)