Skip to content

Commit c7662eb

Browse files
committed
Fix InterpolateHtmlPlugin only replacing the first occurrence (#731)
Fixes facebook/create-react-app#625 (comment).
1 parent f5628ee commit c7662eb

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

packages/react-dev-utils/InterpolateHtmlPlugin.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
// https://github.com/ampedandwired/html-webpack-plugin#events
1717

1818
'use strict';
19+
const escapeStringRegexp = require('escape-string-regexp');
1920

2021
class InterpolateHtmlPlugin {
2122
constructor(replacements) {
@@ -29,7 +30,10 @@ class InterpolateHtmlPlugin {
2930
// Run HTML through a series of user-specified string replacements.
3031
Object.keys(this.replacements).forEach(key => {
3132
const value = this.replacements[key];
32-
data.html = data.html.replace('%' + key + '%', value);
33+
data.html = data.html.replace(
34+
new RegExp('%' + escapeStringRegexp(key) + '%', 'g'),
35+
value
36+
);
3337
});
3438
callback(null, data);
3539
}

packages/react-dev-utils/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
],
2323
"dependencies": {
2424
"chalk": "1.1.3",
25+
"escape-string-regexp": "1.0.5",
2526
"opn": "4.0.2"
2627
},
2728
"peerDependencies": {

0 commit comments

Comments
 (0)