Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on Error in CreateContainerAtPath #166

Closed
tri-adam opened this issue Nov 4, 2021 · 0 comments · Fixed by #167
Closed

Panic on Error in CreateContainerAtPath #166

tri-adam opened this issue Nov 4, 2021 · 0 comments · Fixed by #167
Labels
bug Something isn't working v2 Affects v2 API

Comments

@tri-adam
Copy link
Member

tri-adam commented Nov 4, 2021

In certain error circumstances, CreateContainerAtPath() can panic with an invalid memory address or nil pointer dereference at the following line:

sif/pkg/sif/create.go

Line 318 in bea43fe

f.closeOnUnload = true

In addition to fixing this issue, the test suite should be extended to provide coverage for error conditions in CreateContainerAtPath.
@tri-adam tri-adam added bug Something isn't working v2 Affects v2 API labels Nov 4, 2021
@tri-adam tri-adam mentioned this issue Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v2 Affects v2 API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Panic on Error in CreateContainerAtPath
1 participant
@tri-adam