Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 Demo and Migration Questions #1447

Closed
tacman opened this issue Oct 25, 2023 · 2 comments
Closed

Symfony 7 Demo and Migration Questions #1447

tacman opened this issue Oct 25, 2023 · 2 comments

Comments

@tacman
Copy link
Contributor

tacman commented Oct 25, 2023

I have a version of this demo working with Symfony 7 for everything except doctrine/doctrine-fixtures-bundle

git clone git@github.com:tacman/symfony-demo.git --branch=symfony7 symfony7-demo && cd symfony7-demo
composer install && yarn install && yarn dev
symfony server:start -d
symfony open:local

The PHP part works fine, but there are issues with stimulus. I imagine others who are migrating to Symfony 7 may run into the same issues, so maybe this issue can be the beginning of a migration guide.

In particular, when using both webpack and AssetMapper, should there be TWO app.js files, once that's the entrypoint for the importmap and the other that's for webpack? If I load javascript dependencies via Assetmapper / importmap, will they be available in my webpack-handled javascript?

        {{ encore_entry_script_tags('app') }}

And in particular, how should the stimulus bootstrap file (which of course needs to change from the bridge to the stimulus-bundle). Currently it fails:

 ERROR  Failed to compile with 1 errors                                                                                                                       8:16:37 AM

Module build failed: Module not found:
"./assets/bootstrap.js" contains a reference to the file "@symfony/stimulus-bundle".
This file can not be found, please check it for typos or update it if the file got moved.

Of course, I'd eventually love to get rid of the whole yarn install && yarn dev step, but in practice I'm sure I'll need it in my own projects for a while, and so understanding how to use them both will be important.

@javiereguiluz
Copy link
Member

I'm not answering to your question, but I'm adding a quick comment here: for Symfony Demo, first we'll tag and release a version of the project using Symfony 6.4 (see #1431) and soon after that, we'll update the project to 7.0, tag it and release it.

Also, we don't maintain multiple versions of this project. We only use the current stable version. That's why the version using Symfony 7.0 will be the only maintained version. Thanks!

@smnandre
Copy link
Member

Hello @tacman ! Thanks a lot for all the beta-test you do, that helps a lot

I can just answer for the StimulusBundle bug(s). That is something we are working on, and i now there is hope to release a new version soon, for everyone to test before the Symfony 7.0 release.

But feel free to post specific issues on the symfony/ux repository :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants