Skip to content

Commit 0c17c56

Browse files
bug #57815 [Console][PhpUnitBridge][VarDumper] Fix NO_COLOR empty value handling (alexandre-daubois)
This PR was merged into the 5.4 branch. Discussion ---------- [Console][PhpUnitBridge][VarDumper] Fix `NO_COLOR` empty value handling | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | symfony/symfony#57777 (comment) | License | MIT `NO_COLOR` must be non-empty in order to be considered enabled (https://no-color.org/): > when present and not an empty string (regardless of its value) Commits ------- 6a96ff9116 [Console][PhpUnitBridge][VarDumper] Fix `NO_COLOR` empty value handling
2 parents e4de722 + e0a521e commit 0c17c56

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Dumper/CliDumper.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ private function hasColorSupport($stream): bool
606606
}
607607

608608
// Follow https://no-color.org/
609-
if (isset($_SERVER['NO_COLOR']) || false !== getenv('NO_COLOR')) {
609+
if ('' !== ($_SERVER['NO_COLOR'] ?? getenv('NO_COLOR') ?: '')) {
610610
return false;
611611
}
612612

0 commit comments

Comments
 (0)