Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: taiki-e/pin-project
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 21b6b1048d135de0b0147ce985328817dc6fb107
Choose a base ref
..
head repository: taiki-e/pin-project
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: add5ca59fa97943d665f3ef2150b5a5d64c7595b
Choose a head ref
Showing with 13 additions and 13 deletions.
  1. +8 −8 .github/workflows/ci.yml
  2. +3 −3 README.md
  3. +1 −1 examples/struct-default-expanded.rs
  4. +1 −1 pin-project-internal/src/pin_project/derive.rs
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -23,8 +23,8 @@ jobs:
# This is the minimum supported Rust version of this crate.
# When updating this, the reminder to update the minimum supported
# Rust version in README.md.
- 1.33.0
- 1.36.0
# - 1.33.0
# - 1.36.0
- 1.37.0
- stable
- beta
@@ -35,12 +35,12 @@ jobs:
- macos
# - windows
include:
- build: 1.33.0
os: ubuntu-latest
rust: 1.33.0
- build: 1.36.0
os: ubuntu-latest
rust: 1.36.0
# - build: 1.33.0
# os: ubuntu-latest
# rust: 1.33.0
# - build: 1.36.0
# os: ubuntu-latest
# rust: 1.36.0
- build: 1.37.0
os: ubuntu-latest
rust: 1.37.0
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -11,8 +11,8 @@
[docs-url]: https://docs.rs/pin-project
[license-badge]: https://img.shields.io/crates/l/pin-project.svg
[license]: #license
[rustc-badge]: https://img.shields.io/badge/rustc-1.33+-lightgray.svg
[rustc-url]: https://blog.rust-lang.org/2019/02/28/Rust-1.33.0.html
[rustc-badge]: https://img.shields.io/badge/rustc-1.37+-lightgray.svg
[rustc-url]: https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html

A crate for safe and ergonomic pin-projection.

@@ -29,7 +29,7 @@ Add this to your `Cargo.toml`:
pin-project = "0.4"
```

The current pin-project requires Rust 1.33 or later.
The current pin-project requires Rust 1.37 or later.

## Examples

2 changes: 1 addition & 1 deletion examples/struct-default-expanded.rs
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@ struct __StructProjectionRef<'pin, T, U> {
unpinned: &'pin (U),
}

// All items except projected types are created inside a `const` scope.
// All items except projected types are generated inside a `const` scope.
// This makes it impossible for user code to refer to these types.
const _: () = {
impl<T, U> Struct<T, U> {
2 changes: 1 addition & 1 deletion pin-project-internal/src/pin_project/derive.rs
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ pub(super) fn parse_derive(input: TokenStream) -> Result<TokenStream> {
let unpin_impl = cx.make_unpin_impl();
let drop_impl = cx.make_drop_impl();
proj_items.extend(quote! {
// All items except projected types are created inside a `const` scope.
// All items except projected types are generated inside a `const` scope.
// This makes it impossible for user code to refer to these types.
// However, this prevents Rustdoc from displaying docs for any
// of our types. In particular, users cannot see the