Skip to content

Commit f9c0c3e

Browse files
danbevtargos
authored andcommitted
src: fix compiler warnings in node_report_module
Currently, the following compiler warnings are generated: ../src/node_report_module.cc: In function ‘void report::ShouldReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:132:16: warning: unused variable ‘env’ [-Wunused-variable] 132 | Environment* env = Environment::GetCurrent(info); | ^~~ ../src/node_report_module.cc: In function ‘void report::SetReportOnFatalError( const v8::FunctionCallbackInfo<v8::Value>&)’: ../src/node_report_module.cc:138:16: warning: unused variable ‘env’ [-Wunused-variable] 138 | Environment* env = Environment::GetCurrent(info); | ^~~ This commit removes the unused variables. PR-URL: nodejs#32498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5bc4091 commit f9c0c3e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/node_report_module.cc

-2
Original file line numberDiff line numberDiff line change
@@ -129,13 +129,11 @@ static void SetSignal(const FunctionCallbackInfo<Value>& info) {
129129
}
130130

131131
static void ShouldReportOnFatalError(const FunctionCallbackInfo<Value>& info) {
132-
Environment* env = Environment::GetCurrent(info);
133132
info.GetReturnValue().Set(
134133
node::per_process::cli_options->report_on_fatalerror);
135134
}
136135

137136
static void SetReportOnFatalError(const FunctionCallbackInfo<Value>& info) {
138-
Environment* env = Environment::GetCurrent(info);
139137
CHECK(info[0]->IsBoolean());
140138
node::per_process::cli_options->report_on_fatalerror = info[0]->IsTrue();
141139
}

0 commit comments

Comments
 (0)