distinguish task dependencies: ordering vs resource

there are two types of dependencies between tasks:
- _resource-dependency_: based on resources needed from parent task,
which includes results, workspaces and resources
- _ordering-dependency_: based on runAfter which provides sequencing of
tasks when there may not be resource dependencies

however, it is currently difficult to distinguish between the two

this PR provides a way to know the dependency type and will be useful
for future work such as allowing execution of ordering-dependent tasks
when continueAfterSkip is set to true

Author: jerop

pkg/apis/pipeline/v1beta1/pipeline_types.go

@@ -170,23 +170,31 @@ func (pt PipelineTask) HashKey() string {
 
 func (pt PipelineTask) Deps() []string {
 	deps := []string{}
-	deps = append(deps, pt.RunAfter...)
+
+	deps = append(deps, pt.ResourceDeps()...)
+	deps = append(deps, pt.OrderingDeps()...)
+
+	return deps
+}
+
+func (pt PipelineTask) ResourceDeps() []string {
+	resourceDeps := []string{}
 	if pt.Resources != nil {
 		for _, rd := range pt.Resources.Inputs {
-			deps = append(deps, rd.From...)
+			resourceDeps = append(resourceDeps, rd.From...)
 		}
 	}
 	// Add any dependents from conditional resources.
 	for _, cond := range pt.Conditions {
 		for _, rd := range cond.Resources {
-			deps = append(deps, rd.From...)
+			resourceDeps = append(resourceDeps, rd.From...)
 		}
 		for _, param := range cond.Params {
 			expressions, ok := GetVarSubstitutionExpressionsForParam(param)
 			if ok {
 				resultRefs := NewResultRefs(expressions)
 				for _, resultRef := range resultRefs {
-					deps = append(deps, resultRef.PipelineTask)
+					resourceDeps = append(resourceDeps, resultRef.PipelineTask)
 				}
 			}
 		}
@@ -197,7 +205,7 @@ func (pt PipelineTask) Deps() []string {
 		if ok {
 			resultRefs := NewResultRefs(expressions)
 			for _, resultRef := range resultRefs {
-				deps = append(deps, resultRef.PipelineTask)
+				resourceDeps = append(resourceDeps, resultRef.PipelineTask)
 			}
 		}
 	}
@@ -207,11 +215,31 @@ func (pt PipelineTask) Deps() []string {
 		if ok {
 			resultRefs := NewResultRefs(expressions)
 			for _, resultRef := range resultRefs {
-				deps = append(deps, resultRef.PipelineTask)
+				resourceDeps = append(resourceDeps, resultRef.PipelineTask)
 			}
 		}
 	}
-	return deps
+	return resourceDeps
+}
+
+func (pt PipelineTask) OrderingDeps() []string {
+	orderingDeps := []string{}
+	resourceDeps := pt.ResourceDeps()
+	for _, runAfter := range pt.RunAfter {
+		if !contains(runAfter, resourceDeps) {
+			orderingDeps = append(orderingDeps, runAfter)
+		}
+	}
+	return orderingDeps
+}
+
+func contains(s string, arr []string) bool {
+	for _, elem := range arr {
+		if elem == s {
+			return true
+		}
+	}
+	return false
 }
 
 type PipelineTaskList []PipelineTask