Include message on reason-mismatch failures

mattmoor · tekton-robot · commit 4e66984226fa · 2020-10-26T10:25:19.000Z
diff --git a/test/v1alpha1/wait.go b/test/v1alpha1/wait.go
@@ -210,7 +210,7 @@ func FailedWithReason(reason, name string) ConditionAccessorFn {
 				if c.Reason == reason {
 					return true, nil
 				}
-				return true, fmt.Errorf("%q completed with the wrong reason: %s", name, c.Reason)
+				return true, fmt.Errorf("%q completed with the wrong reason: %s (message: %s)", name, c.Reason, c.Message)
 			} else if c.Status == corev1.ConditionTrue {
 				return true, fmt.Errorf("%q completed successfully, should have been failed with reason %q", name, reason)
 			}
diff --git a/test/wait.go b/test/wait.go
@@ -210,7 +210,7 @@ func FailedWithReason(reason, name string) ConditionAccessorFn {
 				if c.Reason == reason {
 					return true, nil
 				}
-				return true, fmt.Errorf("%q completed with the wrong reason: %s", name, c.Reason)
+				return true, fmt.Errorf("%q completed with the wrong reason: %s (message: %s)", name, c.Reason, c.Message)
 			} else if c.Status == corev1.ConditionTrue {
 				return true, fmt.Errorf("%q completed successfully, should have been failed with reason %q", name, reason)
 			}

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ func FailedWithReason(reason, name string) ConditionAccessorFn {`
`210`	`210`	`if c.Reason == reason {`
`211`	`211`	`return true, nil`
`212`	`212`	`}`
`213`		`- return true, fmt.Errorf("%q completed with the wrong reason: %s", name, c.Reason)`
	`213`	`+ return true, fmt.Errorf("%q completed with the wrong reason: %s (message: %s)", name, c.Reason, c.Message)`
`214`	`214`	`} else if c.Status == corev1.ConditionTrue {`
`215`	`215`	`return true, fmt.Errorf("%q completed successfully, should have been failed with reason %q", name, reason)`
`216`	`216`	`}`