Skip to content

Commit 758d25a

Browse files
Scotttekton-robot
Scott
authored andcommitted
Pass test ctx to taskrun reconciler instead of background ctx
Prior to this commit the test reconciler was being passed a background context to its Reconciler method in TestReconcileValidDefaultWorkspace. This commit passes the test assets context instead which will hopefully be immediately up-to-date with configmap changes like the Default TaskRun Workspace Binding config.
1 parent f37860f commit 758d25a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/reconciler/taskrun/taskrun_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -2566,7 +2566,7 @@ func TestReconcileValidDefaultWorkspace(t *testing.T) {
25662566
t.Fatal(err)
25672567
}
25682568

2569-
if err := testAssets.Controller.Reconciler.Reconcile(context.Background(), getRunName(taskRun)); err != nil {
2569+
if err := testAssets.Controller.Reconciler.Reconcile(testAssets.Ctx, getRunName(taskRun)); err != nil {
25702570
t.Errorf("Expected no error reconciling valid TaskRun but got %v", err)
25712571
}
25722572

0 commit comments

Comments
 (0)