Skip to content

Commit 9b15dc2

Browse files
mattmoortekton-robot
authored andcommitted
Fix error path through test.
In a downstream flake I saw this error: ``` timeout_test.go:234: Error waiting for TaskRun pipeline-task-timeout-hdwboxrg-pipelinetask1-2tqsx to be running: %!s(<nil>) ``` This fixes the format string, and corrects what is likely a bug where `err` isn't properly set when printed.
1 parent 26577d4 commit 9b15dc2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

test/timeout_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ func TestPipelineRunTimeout(t *testing.T) {
107107
}
108108

109109
for i := 1; i <= len(taskrunList.Items); i++ {
110-
if <-errChan != nil {
111-
t.Errorf("Error waiting for TaskRun %s to be running: %s", taskrunList.Items[i-1].Name, err)
110+
if err := <-errChan; err != nil {
111+
t.Errorf("Error waiting for TaskRun %s to be running: %v", taskrunList.Items[i-1].Name, err)
112112
}
113113
}
114114

test/v1alpha1/timeout_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,8 @@ func TestPipelineTaskTimeout(t *testing.T) {
230230
}
231231

232232
for i := 1; i <= len(taskrunList.Items); i++ {
233-
if <-errChan != nil {
234-
t.Errorf("Error waiting for TaskRun %s to be running: %s", taskrunList.Items[i-1].Name, err)
233+
if err := <-errChan; err != nil {
234+
t.Errorf("Error waiting for TaskRun %s to be running: %v", taskrunList.Items[i-1].Name, err)
235235
}
236236
}
237237

0 commit comments

Comments
 (0)