Skip to content

Commit cb85f1d

Browse files
barthy1tekton-robot
authored andcommitted
Fix TestTaskRunStatus test to run on s390x
TestTaskRunStatus test fails for s390x architecture because busybox image in the code is specified with concrete SHA. SHA is unique for each image and as a result for s390x case the amd64 image with the SHA is pulled. Test failed. Adding s390x specific SHA to s390x build solves this problem. Signed-off-by: Yulia Gaponenko <yulia.gaponenko1@de.ibm.com>
1 parent cec3027 commit cb85f1d

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

test/taskrun_test.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ limitations under the License.
1919
package test
2020

2121
import (
22+
"runtime"
2223
"strings"
2324
"testing"
2425

@@ -126,13 +127,17 @@ func TestTaskRunStatus(t *testing.T) {
126127
taskRunName := "status-taskrun"
127128

128129
fqImageName := "busybox@sha256:895ab622e92e18d6b461d671081757af7dbaa3b00e3e28e12505af7817f73649"
130+
if runtime.GOARCH == "s390x" {
131+
fqImageName = "busybox@sha256:4f47c01fa91355af2865ac10fef5bf6ec9c7f42ad2321377c21e844427972977"
132+
}
133+
129134
t.Logf("Creating Task and TaskRun in namespace %s", namespace)
130135
task := &v1beta1.Task{
131136
ObjectMeta: metav1.ObjectMeta{Name: "status-task", Namespace: namespace},
132137
Spec: v1beta1.TaskSpec{
133138
// This was the digest of the latest tag as of 8/12/2019
134139
Steps: []v1beta1.Step{{Container: corev1.Container{
135-
Image: "busybox@sha256:895ab622e92e18d6b461d671081757af7dbaa3b00e3e28e12505af7817f73649",
140+
Image: fqImageName,
136141
Command: []string{"/bin/sh"},
137142
Args: []string{"-c", "echo hello"},
138143
}}},

0 commit comments

Comments
 (0)