Fix errcheck in ./common/rpc/ (#3752)

Author: MichaelSnowden

common/rpc/interceptor/caller_info_test.go

@@ -125,7 +125,7 @@ func (s *callerInfoSuite) TestIntercept_CallerName() {
 		ctx := testCase.setupIncomingCtx()
 
 		var resultingCtx context.Context
-		s.interceptor.Intercept(
+		_, err := s.interceptor.Intercept(
 			ctx,
 			testCase.request,
 			&grpc.UnaryServerInfo{},
@@ -134,6 +134,7 @@ func (s *callerInfoSuite) TestIntercept_CallerName() {
 				return nil, nil
 			},
 		)
+		s.NoError(err)
 
 		actualCallerName := headers.GetCallerInfo(resultingCtx).CallerName
 		s.Equal(testCase.expectedCallerName, actualCallerName)
@@ -186,7 +187,7 @@ func (s *callerInfoSuite) TestIntercept_CallerType() {
 		ctx := testCase.setupIncomingCtx()
 
 		var resultingCtx context.Context
-		s.interceptor.Intercept(
+		_, err := s.interceptor.Intercept(
 			ctx,
 			testCase.request,
 			&grpc.UnaryServerInfo{},
@@ -195,6 +196,7 @@ func (s *callerInfoSuite) TestIntercept_CallerType() {
 				return nil, nil
 			},
 		)
+		s.NoError(err)
 
 		actualCallerType := headers.GetCallerInfo(resultingCtx).CallerType
 		s.Equal(testCase.expectedCallerType, actualCallerType)
@@ -259,7 +261,7 @@ func (s *callerInfoSuite) TestIntercept_CallOrigin() {
 		ctx := testCase.setupIncomingCtx()
 
 		var resultingCtx context.Context
-		s.interceptor.Intercept(
+		_, err := s.interceptor.Intercept(
 			ctx,
 			testCase.request,
 			serverInfo,
@@ -268,6 +270,7 @@ func (s *callerInfoSuite) TestIntercept_CallOrigin() {
 				return nil, nil
 			},
 		)
+		s.NoError(err)
 
 		actualCallOrigin := headers.GetCallerInfo(resultingCtx).CallOrigin
 		s.Equal(testCase.expectedCallOrigin, actualCallOrigin)

common/rpc/interceptor/sdk_version_test.go

@@ -47,33 +47,38 @@ func TestSDKVersionRecorder(t *testing.T) {
 
 	// Record first tuple
 	ctx := headers.SetVersionsForTests(context.Background(), sdkVersion, headers.ClientNameGoSDK, headers.SupportedServerVersions, headers.AllFeatures)
-	interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
+	_, err := interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
 		return nil, nil
 	})
+	assert.NoError(t, err)
 
 	// Record second tuple
 	ctx = headers.SetVersionsForTests(context.Background(), sdkVersion, headers.ClientNameTypeScriptSDK, headers.SupportedServerVersions, headers.AllFeatures)
-	interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
+	_, err = interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
 		return nil, nil
 	})
+	assert.NoError(t, err)
 
 	// Do not record when over capacity
 	ctx = headers.SetVersionsForTests(context.Background(), sdkVersion, headers.ClientNameJavaSDK, headers.SupportedServerVersions, headers.AllFeatures)
-	interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
+	_, err = interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
 		return nil, nil
 	})
+	assert.NoError(t, err)
 
 	// Empty SDK version should not be recorded
 	ctx = headers.SetVersionsForTests(context.Background(), "", headers.ClientNameGoSDK, headers.SupportedServerVersions, headers.AllFeatures)
-	interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
+	_, err = interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
 		return nil, nil
 	})
+	assert.NoError(t, err)
 
 	// Empty SDK name should not be recorded
 	ctx = headers.SetVersionsForTests(context.Background(), sdkVersion, "", headers.SupportedServerVersions, headers.AllFeatures)
-	interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
+	_, err = interceptor.Intercept(ctx, nil, nil, func(ctx context.Context, req interface{}) (interface{}, error) {
 		return nil, nil
 	})
+	assert.NoError(t, err)
 
 	info := interceptor.GetAndResetSDKInfo()
 	sort.SliceStable(info, func(i, j int) bool {