Skip to content

Commit 7ab7e9c

Browse files
authored
Metering metadata propagation (#3965)
* Update proto submodule
1 parent 2db4175 commit 7ab7e9c

File tree

6 files changed

+16
-10
lines changed

6 files changed

+16
-10
lines changed

go.mod

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ require (
4444
go.opentelemetry.io/otel/metric v0.34.0
4545
go.opentelemetry.io/otel/sdk v1.11.2
4646
go.opentelemetry.io/otel/sdk/metric v0.34.0
47-
go.temporal.io/api v1.17.0
47+
go.temporal.io/api v1.18.1
4848
go.temporal.io/sdk v1.21.1
4949
go.temporal.io/version v0.3.0
5050
go.uber.org/atomic v1.10.0
@@ -121,7 +121,7 @@ require (
121121
go.uber.org/dig v1.15.0 // indirect
122122
golang.org/x/crypto v0.3.0 // indirect
123123
golang.org/x/mod v0.7.0 // indirect
124-
golang.org/x/net v0.6.0 // indirect
124+
golang.org/x/net v0.7.0 // indirect
125125
golang.org/x/sys v0.5.0 // indirect
126126
golang.org/x/text v0.7.0 // indirect
127127
golang.org/x/tools v0.3.0 // indirect

go.sum

+4-4
Original file line numberDiff line numberDiff line change
@@ -867,8 +867,8 @@ go.opentelemetry.io/proto/otlp v0.15.0/go.mod h1:H7XAot3MsfNsj7EXtrA2q5xSNQ10UqI
867867
go.opentelemetry.io/proto/otlp v0.19.0 h1:IVN6GR+mhC4s5yfcTbmzHYODqvWAp3ZedA2SJPI1Nnw=
868868
go.opentelemetry.io/proto/otlp v0.19.0/go.mod h1:H7XAot3MsfNsj7EXtrA2q5xSNQ10UqI405h3+duxN4U=
869869
go.temporal.io/api v1.16.0/go.mod h1:u3qLbaVTffmcZQbf9ueB+16LKmhkftH79SJOV517MDk=
870-
go.temporal.io/api v1.17.0 h1:fVhGK9+FNAZv34YJGGnJaevnvZVsIuCFdOVhlikreeY=
871-
go.temporal.io/api v1.17.0/go.mod h1:sCN2tPg4ZlrE0GDp8o1X40MBP7X4C9c7p7lzVS18qeU=
870+
go.temporal.io/api v1.18.1 h1:kC3TS0iVXaAKe12L39I37b9X59x4p7E6512EfG/+RCU=
871+
go.temporal.io/api v1.18.1/go.mod h1:VWdEGKUWRYKMkKJPo3wONuGZKay+d5L641b+JRuw0Bo=
872872
go.temporal.io/sdk v1.21.1 h1:SJCzSsZLBsFiHniJ+E7Yy74pcAs1lg7NbFnsUJ4ggIM=
873873
go.temporal.io/sdk v1.21.1/go.mod h1:Pq3Mp7p0lWNFM+YS2guBy8V/lJySh329AcyS+Wj/Wmo=
874874
go.temporal.io/version v0.3.0 h1:dMrei9l9NyHt8nG6EB8vAwDLLTwx2SvRyucCSumAiig=
@@ -1008,8 +1008,8 @@ golang.org/x/net v0.1.0/go.mod h1:Cx3nUiGt4eDBEyega/BKRp+/AlGL8hYe7U9odMt2Cco=
10081008
golang.org/x/net v0.2.0/go.mod h1:KqCZLdyyvdV855qA2rE3GC2aiw5xGR5TEjj8smXukLY=
10091009
golang.org/x/net v0.4.0/go.mod h1:MBQ8lrhLObU/6UmLb4fmbmk5OcyYmqtbGd/9yIeKjEE=
10101010
golang.org/x/net v0.5.0/go.mod h1:DivGGAXEgPSlEBzxGzZI+ZLohi+xUj054jfeKui00ws=
1011-
golang.org/x/net v0.6.0 h1:L4ZwwTvKW9gr0ZMS1yrHD9GZhIuVjOBBnaKH+SPQK0Q=
1012-
golang.org/x/net v0.6.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs=
1011+
golang.org/x/net v0.7.0 h1:rJrUqqhjsgNp7KqAIc25s9pZnjU7TUcSY7HcVZjdn1g=
1012+
golang.org/x/net v0.7.0/go.mod h1:2Tu9+aMcznHK/AK1HMvgo6xiTLG5rD5rZLDS+rp2Bjs=
10131013
golang.org/x/oauth2 v0.0.0-20180821212333-d2e6202438be/go.mod h1:N/0e6XlmueqKjAGxoOufVs8QHGRruUQn6yWY3a++T0U=
10141014
golang.org/x/oauth2 v0.0.0-20190226205417-e64efc72b421/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=
10151015
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45/go.mod h1:gOpvHmFTYa4IltrdGE7lF6nIHvwfUNPOp7c8zoXwtLw=

service/history/workflow/history_builder.go

+2
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,7 @@ func (b *HistoryBuilder) AddWorkflowTaskCompletedEvent(
250250
identity string,
251251
checksum string,
252252
sdkMetadata *sdkpb.WorkflowTaskCompletedMetadata,
253+
meteringMetadata *commonpb.MeteringMetadata,
253254
) *historypb.HistoryEvent {
254255
event := b.createNewHistoryEvent(enumspb.EVENT_TYPE_WORKFLOW_TASK_COMPLETED, b.timeSource.Now())
255256
event.Attributes = &historypb.HistoryEvent_WorkflowTaskCompletedEventAttributes{
@@ -259,6 +260,7 @@ func (b *HistoryBuilder) AddWorkflowTaskCompletedEvent(
259260
Identity: identity,
260261
BinaryChecksum: checksum,
261262
SdkMetadata: sdkMetadata,
263+
MeteringMetadata: meteringMetadata,
262264
},
263265
}
264266

service/history/workflow/history_builder_test.go

+6-3
Original file line numberDiff line numberDiff line change
@@ -668,13 +668,15 @@ func (s *historyBuilderSuite) TestWorkflowTaskCompleted() {
668668
scheduledEventID := rand.Int63()
669669
startedEventID := rand.Int63()
670670
checksum := "random checksum"
671-
metadata := &sdkpb.WorkflowTaskCompletedMetadata{CoreUsedFlags: []uint32{1, 2, 3}, LangUsedFlags: []uint32{4, 5, 6}}
671+
sdkMetadata := &sdkpb.WorkflowTaskCompletedMetadata{CoreUsedFlags: []uint32{1, 2, 3}, LangUsedFlags: []uint32{4, 5, 6}}
672+
meteringMeta := &commonpb.MeteringMetadata{NonfirstLocalActivityExecutionAttempts: 42}
672673
event := s.historyBuilder.AddWorkflowTaskCompletedEvent(
673674
scheduledEventID,
674675
startedEventID,
675676
testIdentity,
676677
checksum,
677-
metadata,
678+
sdkMetadata,
679+
meteringMeta,
678680
)
679681
s.Equal(event, s.flush())
680682
s.Equal(&historypb.HistoryEvent{
@@ -689,7 +691,8 @@ func (s *historyBuilderSuite) TestWorkflowTaskCompleted() {
689691
StartedEventId: startedEventID,
690692
Identity: testIdentity,
691693
BinaryChecksum: checksum,
692-
SdkMetadata: metadata,
694+
SdkMetadata: sdkMetadata,
695+
MeteringMetadata: meteringMeta,
693696
},
694697
},
695698
}, event)

service/history/workflow/workflow_task_state_machine.go

+1
Original file line numberDiff line numberDiff line change
@@ -540,6 +540,7 @@ func (m *workflowTaskStateMachine) AddWorkflowTaskCompletedEvent(
540540
request.Identity,
541541
request.BinaryChecksum,
542542
request.SdkMetadata,
543+
request.MeteringMetadata,
543544
)
544545

545546
err := m.afterAddWorkflowTaskCompletedEvent(event, maxResetPoints)

0 commit comments

Comments
 (0)