Skip to content

Commit 7e54876

Browse files
alexshtinalexshtin
authored
Rename UpdateWorkflow to UpdateWorkflowExecution (#3832)
1 parent 4c71899 commit 7e54876

31 files changed

+601
-572
lines changed

‎api/historyservice/v1/request_response.pb.go

+346-346
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎api/historyservice/v1/service.pb.go

+92-92
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎api/historyservicemock/v1/service.pb.mock.go

+14-14
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/frontend/client_gen.go

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/frontend/metric_client_gen.go

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/frontend/retryable_client_gen.go

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/history/client_gen.go

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/history/metric_client_gen.go

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎client/history/retryable_client_gen.go

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎common/metrics/metric_defs.go

+10-10
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ const (
298298
DCRedirectionUpdateWorkerBuildIdOrderingScope = "DCRedirectionUpdateWorkerBuildIdOrdering"
299299
// DCRedirectionGetWorkerBuildIdOrderingScope tracks RPC calls for dc redirection
300300
DCRedirectionGetWorkerBuildIdOrderingScope = "DCRedirectionGetWorkerBuildIdOrdering"
301-
// DCRedirectionUpdateWorkflowScope tracks RPC calls for dc redirection
302-
DCRedirectionUpdateWorkflowScope = "DCRedirectionUpdateWorkflow"
301+
// DCRedirectionUpdateWorkflowExecutionScope tracks RPC calls for dc redirection
302+
DCRedirectionUpdateWorkflowExecutionScope = "DCRedirectionUpdateWorkflowExecution"
303303
// DCRedirectionDescribeBatchOperationScope tracks RPC calls for dc redirection
304304
DCRedirectionDescribeBatchOperationScope = "DCRedirectionDescribeBatchOperation"
305305
// DCRedirectionListBatchOperationsScope tracks RPC calls for dc redirection
@@ -430,8 +430,8 @@ const (
430430
FrontendClientListSchedulesScope = "FrontendClientListSchedules"
431431
// FrontendClientUpdateWorkerBuildIdOrderingScope tracks RPC calls to frontend service
432432
FrontendClientUpdateWorkerBuildIdOrderingScope = "FrontendClientUpdateWorkerBuildIdOrdering"
433-
// FrontendClientUpdateWorkflowScope tracks RPC calls to frontend service
434-
FrontendClientUpdateWorkflowScope = "FrontendClientUpdateWorkflow"
433+
// FrontendClientUpdateWorkflowExecutionScope tracks RPC calls to frontend service
434+
FrontendClientUpdateWorkflowExecutionScope = "FrontendClientUpdateWorkflowExecution"
435435
// FrontendClientGetWorkerBuildIdOrderingScope tracks RPC calls to frontend service
436436
FrontendClientGetWorkerBuildIdOrderingScope = "FrontendClientGetWorkerBuildIdOrdering"
437437
// FrontendClientDescribeBatchOperationScope tracks RPC calls to frontend service
@@ -482,8 +482,8 @@ const (
482482
HistoryClientRemoveSignalMutableStateScope = "HistoryClientRemoveSignalMutableState"
483483
// HistoryClientTerminateWorkflowExecutionScope tracks RPC calls to history service
484484
HistoryClientTerminateWorkflowExecutionScope = "HistoryClientTerminateWorkflowExecution"
485-
// HistoryClientUpdateWorkflowScope tracks RPC calls to history service
486-
HistoryClientUpdateWorkflowScope = "HistoryClientUpdateWorkflow"
485+
// HistoryClientUpdateWorkflowExecutionScope tracks RPC calls to history service
486+
HistoryClientUpdateWorkflowExecutionScope = "HistoryClientUpdateWorkflowExecution"
487487
// HistoryClientDeleteWorkflowExecutionScope tracks RPC calls to history service
488488
HistoryClientDeleteWorkflowExecutionScope = "HistoryClientDeleteWorkflowExecution"
489489
// HistoryClientResetWorkflowExecutionScope tracks RPC calls to history service
@@ -921,8 +921,8 @@ const (
921921
FrontendUpdateWorkerBuildIdOrderingScope = "UpdateWorkerBuildIdOrdering"
922922
// FrontendGetWorkerBuildIdOrderingScope is the metric scope for frontend.GetWorkerBuildIdOrderingScope = "GetWorkerBuildIdOrderingScope is the metric scope for frontend.GetWorkerBuildIdOrdering"
923923
FrontendGetWorkerBuildIdOrderingScope = "GetWorkerBuildIdOrdering"
924-
// FrontendUpdateWorkflowScope is the metric scope for frontend.UpdateWorkflow
925-
FrontendUpdateWorkflowScope = "UpdateWorkflow"
924+
// FrontendUpdateWorkflowExecutionScope is the metric scope for frontend.UpdateWorkflowExecution
925+
FrontendUpdateWorkflowExecutionScope = "UpdateWorkflowExecution"
926926
// FrontendDescribeBatchOperationScope is the metric scope for frontend.DescribeBatchOperation
927927
FrontendDescribeBatchOperationScope = "DescribeBatchOperation"
928928
// FrontendListBatchOperationsScope is the metric scope for frontend.ListBatchOperations
@@ -1021,8 +1021,8 @@ const (
10211021
HistoryDescribeHistoryHostScope = "DescribeHistoryHost"
10221022
// HistoryDeleteWorkflowVisibilityRecordScope is the scope used by delete workflow visibility record API
10231023
HistoryDeleteWorkflowVisibilityRecordScope = "DeleteWorkflowVisibilityRecord"
1024-
// HistoryUpdateWorkflowScope is the scope used by update workflow API
1025-
HistoryUpdateWorkflowScope = "UpdateWorkflow"
1024+
// HistoryUpdateWorkflowExecutionScope is the scope used by update workflow execution API
1025+
HistoryUpdateWorkflowExecutionScope = "UpdateWorkflowExecution"
10261026
// HistoryResetWorkflowExecutionScope tracks ResetWorkflowExecution API calls received by service
10271027
HistoryResetWorkflowExecutionScope = "ResetWorkflowExecution"
10281028
// HistoryQueryWorkflowScope tracks QueryWorkflow API calls received by service

‎common/persistence/client/quotas.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ var (
4444
"RequestCancelWorkflowExecution": 0,
4545
"TerminateWorkflowExecution": 0,
4646
"GetWorkflowExecutionHistory": 0,
47-
"UpdateWorkflow": 0,
47+
"UpdateWorkflowExecution": 0,
4848
}
4949

5050
BackgroundTypeAPIPriorityOverride = map[string]int{

‎go.mod

+4-4
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ require (
4444
go.opentelemetry.io/otel/metric v0.33.0
4545
go.opentelemetry.io/otel/sdk v1.11.1
4646
go.opentelemetry.io/otel/sdk/metric v0.31.0
47-
go.temporal.io/api v1.14.1-0.20230123181040-6d7a91e07c31
48-
go.temporal.io/sdk v1.20.0
47+
go.temporal.io/api v1.15.1-0.20230125004443-42737e40d339
48+
go.temporal.io/sdk v1.20.1-0.20230125015921-1fe6824cedfe
4949
go.temporal.io/version v0.3.0
5050
go.uber.org/atomic v1.10.0
5151
go.uber.org/fx v1.18.2
@@ -55,7 +55,7 @@ require (
5555
golang.org/x/oauth2 v0.2.0
5656
golang.org/x/time v0.2.0
5757
google.golang.org/api v0.103.0
58-
google.golang.org/grpc v1.52.0
58+
google.golang.org/grpc v1.52.1
5959
google.golang.org/grpc/examples v0.0.0-20221201195934-736197138d20
6060
gopkg.in/square/go-jose.v2 v2.6.0
6161
gopkg.in/validator.v2 v2.0.1
@@ -127,7 +127,7 @@ require (
127127
golang.org/x/tools v0.3.0 // indirect
128128
golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
129129
google.golang.org/appengine v1.6.7 // indirect
130-
google.golang.org/genproto v0.0.0-20230119192704-9d59e20e5cd1 // indirect
130+
google.golang.org/genproto v0.0.0-20230124163310-31e0e69b6fc2 // indirect
131131
google.golang.org/protobuf v1.28.1 // indirect
132132
gopkg.in/inf.v0 v0.9.1 // indirect
133133
lukechampine.com/uint128 v1.2.0 // indirect

‎go.sum

+8-10
Original file line numberDiff line numberDiff line change
@@ -840,11 +840,10 @@ go.opentelemetry.io/otel/trace v1.11.1/go.mod h1:f/Q9G7vzk5u91PhbmKbg1Qn0rzH1LJ4
840840
go.opentelemetry.io/proto/otlp v0.7.0/go.mod h1:PqfVotwruBrMGOCsRd/89rSnXhoiJIqeYNgFYFoEGnI=
841841
go.opentelemetry.io/proto/otlp v0.19.0 h1:IVN6GR+mhC4s5yfcTbmzHYODqvWAp3ZedA2SJPI1Nnw=
842842
go.opentelemetry.io/proto/otlp v0.19.0/go.mod h1:H7XAot3MsfNsj7EXtrA2q5xSNQ10UqI405h3+duxN4U=
843-
go.temporal.io/api v1.14.0/go.mod h1:tfiIwNOKqwboFAyJ6t+Wz0dtZQlydZqlGetFEU1em6o=
844-
go.temporal.io/api v1.14.1-0.20230123181040-6d7a91e07c31 h1:1uSLdXq1HOjzFNzDLJxmEDC63BEBZzm1ugq4Kk3kKsc=
845-
go.temporal.io/api v1.14.1-0.20230123181040-6d7a91e07c31/go.mod h1:iOTECB2ZzJykSBxAyMSqhIluACJgjCWszdN8wPKKjao=
846-
go.temporal.io/sdk v1.20.0 h1:+Omx4azj6NNuq+Qnf4/lrereNLKHKeSvE8AqG2bW4Vg=
847-
go.temporal.io/sdk v1.20.0/go.mod h1:5W9bRe+0aMCiD7vJnYB1co4xMqziUqQuIHsmOAaDWvo=
843+
go.temporal.io/api v1.15.1-0.20230125004443-42737e40d339 h1:7p2abcEmI8MVqPoBt+mbcHm6t+6fUYS3dUEEAFyzloM=
844+
go.temporal.io/api v1.15.1-0.20230125004443-42737e40d339/go.mod h1:dbi2T2T/PVw0jOHF0pdc8XFDFGQoMQeNq7F0ClTKwlU=
845+
go.temporal.io/sdk v1.20.1-0.20230125015921-1fe6824cedfe h1:mlyDvuKMuxCTcEgmeZs+Qd/x69jyT/Jwq1ULhJGfPbU=
846+
go.temporal.io/sdk v1.20.1-0.20230125015921-1fe6824cedfe/go.mod h1:KtPAB/8+lVNm0aP0W5wLCyxXfHoQJbYNfM4+SfVnsJc=
848847
go.temporal.io/version v0.3.0 h1:dMrei9l9NyHt8nG6EB8vAwDLLTwx2SvRyucCSumAiig=
849848
go.temporal.io/version v0.3.0/go.mod h1:UA9S8/1LaKYae6TyD9NaPMJTZb911JcbqghI2CBSP78=
850849
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
@@ -1366,9 +1365,8 @@ google.golang.org/genproto v0.0.0-20221114212237-e4508ebdbee1/go.mod h1:rZS5c/ZV
13661365
google.golang.org/genproto v0.0.0-20221117204609-8f9c96812029/go.mod h1:rZS5c/ZVYMaOGBfO68GWtjOw/eLaZM1X6iVtgjZ+EWg=
13671366
google.golang.org/genproto v0.0.0-20221118155620-16455021b5e6/go.mod h1:rZS5c/ZVYMaOGBfO68GWtjOw/eLaZM1X6iVtgjZ+EWg=
13681367
google.golang.org/genproto v0.0.0-20221201164419-0e50fba7f41c/go.mod h1:rZS5c/ZVYMaOGBfO68GWtjOw/eLaZM1X6iVtgjZ+EWg=
1369-
google.golang.org/genproto v0.0.0-20221207170731-23e4bf6bdc37/go.mod h1:RGgjbofJ8xD9Sq1VVhDM1Vok1vRONV+rg+CjzG4SZKM=
1370-
google.golang.org/genproto v0.0.0-20230119192704-9d59e20e5cd1 h1:wSjSSQW7LuPdv3m1IrSN33nVxH/kID6OIKy+FMwGB2k=
1371-
google.golang.org/genproto v0.0.0-20230119192704-9d59e20e5cd1/go.mod h1:RGgjbofJ8xD9Sq1VVhDM1Vok1vRONV+rg+CjzG4SZKM=
1368+
google.golang.org/genproto v0.0.0-20230124163310-31e0e69b6fc2 h1:O97sLx/Xmb/KIZHB/2/BzofxBs5QmmR0LcihPtllmbc=
1369+
google.golang.org/genproto v0.0.0-20230124163310-31e0e69b6fc2/go.mod h1:RGgjbofJ8xD9Sq1VVhDM1Vok1vRONV+rg+CjzG4SZKM=
13721370
google.golang.org/grpc v1.12.0/go.mod h1:yo6s7OP7yaDglbqo1J04qKzAhqBH6lvTonzMVmEdcZw=
13731371
google.golang.org/grpc v1.19.0/go.mod h1:mqu4LbDTu4XGKhr4mRzUsmM4RtVoemTSY81AxZiDr8c=
13741372
google.golang.org/grpc v1.20.1/go.mod h1:10oTOabMzJvdu6/UiuZezV6QK5dSlG84ov/aaiqXj38=
@@ -1407,8 +1405,8 @@ google.golang.org/grpc v1.49.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCD
14071405
google.golang.org/grpc v1.50.0/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI=
14081406
google.golang.org/grpc v1.50.1/go.mod h1:ZgQEeidpAuNRZ8iRrlBKXZQP1ghovWIVhdJRyCDK+GI=
14091407
google.golang.org/grpc v1.51.0/go.mod h1:wgNDFcnuBGmxLKI/qn4T+m5BtEBYXJPvibbUPsAIPww=
1410-
google.golang.org/grpc v1.52.0 h1:kd48UiU7EHsV4rnLyOJRuP/Il/UHE7gdDAQ+SZI7nZk=
1411-
google.golang.org/grpc v1.52.0/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY=
1408+
google.golang.org/grpc v1.52.1 h1:2NpOPk5g5Xtb0qebIEs7hNIa++PdtZLo2AQUpc1YnSU=
1409+
google.golang.org/grpc v1.52.1/go.mod h1:pu6fVzoFb+NBYNAvQL08ic+lvB2IojljRYuun5vorUY=
14121410
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0/go.mod h1:6Kw0yEErY5E/yWrBtf03jp27GLLJujG4z/JK95pnjjw=
14131411
google.golang.org/grpc/examples v0.0.0-20221201195934-736197138d20 h1:c4fmRt11lwyTYMMEA3IYCZR/xN7FEAJpwvPziaGXugs=
14141412
google.golang.org/grpc/examples v0.0.0-20221201195934-736197138d20/go.mod h1:jMMKnsR3nPEOSsgT/Le2GxpknJOBOQms0nWb0JRgeUM=

‎proto/api

Submodule api updated 34 files

‎proto/internal/temporal/server/api/historyservice/v1/request_response.proto

+4-4
Original file line numberDiff line numberDiff line change
@@ -617,11 +617,11 @@ message DeleteWorkflowVisibilityRecordResponse {
617617

618618
// (-- api-linter: core::0134=disabled
619619
// aip.dev/not-precedent: This service does not follow the update method AIP --)
620-
message UpdateWorkflowRequest {
620+
message UpdateWorkflowExecutionRequest {
621621
string namespace_id = 1;
622-
temporal.api.workflowservice.v1.UpdateWorkflowRequest request = 2;
622+
temporal.api.workflowservice.v1.UpdateWorkflowExecutionRequest request = 2;
623623
}
624624

625-
message UpdateWorkflowResponse {
626-
temporal.api.workflowservice.v1.UpdateWorkflowResponse response = 1;
625+
message UpdateWorkflowExecutionResponse {
626+
temporal.api.workflowservice.v1.UpdateWorkflowExecutionResponse response = 1;
627627
}

‎proto/internal/temporal/server/api/historyservice/v1/service.proto

+1-1
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,6 @@ service HistoryService {
281281

282282
// (-- api-linter: core::0134=disabled
283283
// aip.dev/not-precedent: This service does not follow the update method API --)
284-
rpc UpdateWorkflow(UpdateWorkflowRequest) returns (UpdateWorkflowResponse) {
284+
rpc UpdateWorkflowExecution(UpdateWorkflowExecutionRequest) returns (UpdateWorkflowExecutionResponse) {
285285
}
286286
}

0 commit comments

Comments
 (0)