Skip to content

Commit c357812

Browse files
authored
Propagate SDK Metadata & add capability (#3944)
* Update protos as well
1 parent 5d6d93c commit c357812

File tree

7 files changed

+13
-4
lines changed

7 files changed

+13
-4
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ require (
4444
go.opentelemetry.io/otel/metric v0.34.0
4545
go.opentelemetry.io/otel/sdk v1.11.2
4646
go.opentelemetry.io/otel/sdk/metric v0.34.0
47-
go.temporal.io/api v1.16.1-0.20230210062249-90fb5b4a7b41
47+
go.temporal.io/api v1.17.0
4848
go.temporal.io/sdk v1.21.0
4949
go.temporal.io/version v0.3.0
5050
go.uber.org/atomic v1.10.0

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -867,8 +867,8 @@ go.opentelemetry.io/proto/otlp v0.15.0/go.mod h1:H7XAot3MsfNsj7EXtrA2q5xSNQ10UqI
867867
go.opentelemetry.io/proto/otlp v0.19.0 h1:IVN6GR+mhC4s5yfcTbmzHYODqvWAp3ZedA2SJPI1Nnw=
868868
go.opentelemetry.io/proto/otlp v0.19.0/go.mod h1:H7XAot3MsfNsj7EXtrA2q5xSNQ10UqI405h3+duxN4U=
869869
go.temporal.io/api v1.16.0/go.mod h1:u3qLbaVTffmcZQbf9ueB+16LKmhkftH79SJOV517MDk=
870-
go.temporal.io/api v1.16.1-0.20230210062249-90fb5b4a7b41 h1:Sa/a1lh4GpWDqP7JLz5VApkd9+bXH4G+8wdsgnYlS7U=
871-
go.temporal.io/api v1.16.1-0.20230210062249-90fb5b4a7b41/go.mod h1:sCN2tPg4ZlrE0GDp8o1X40MBP7X4C9c7p7lzVS18qeU=
870+
go.temporal.io/api v1.17.0 h1:fVhGK9+FNAZv34YJGGnJaevnvZVsIuCFdOVhlikreeY=
871+
go.temporal.io/api v1.17.0/go.mod h1:sCN2tPg4ZlrE0GDp8o1X40MBP7X4C9c7p7lzVS18qeU=
872872
go.temporal.io/sdk v1.21.0 h1:nBWUAhl3ZWeOjvK1lesi8HgXU5Z9KQ6v0d9ooNWK0ZU=
873873
go.temporal.io/sdk v1.21.0/go.mod h1:Pq3Mp7p0lWNFM+YS2guBy8V/lJySh329AcyS+Wj/Wmo=
874874
go.temporal.io/version v0.3.0 h1:dMrei9l9NyHt8nG6EB8vAwDLLTwx2SvRyucCSumAiig=

service/frontend/workflow_handler.go

+1
Original file line numberDiff line numberDiff line change
@@ -2879,6 +2879,7 @@ func (wh *WorkflowHandler) GetSystemInfo(ctx context.Context, request *workflows
28792879
EncodedFailureAttributes: true,
28802880
UpsertMemo: true,
28812881
EagerWorkflowStart: true,
2882+
SdkMetadata: true,
28822883
},
28832884
}, nil
28842885
}

service/history/workflow/history_builder.go

+3
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import (
3232
enumspb "go.temporal.io/api/enums/v1"
3333
failurepb "go.temporal.io/api/failure/v1"
3434
historypb "go.temporal.io/api/history/v1"
35+
sdkpb "go.temporal.io/api/sdk/v1"
3536
taskqueuepb "go.temporal.io/api/taskqueue/v1"
3637
updatepb "go.temporal.io/api/update/v1"
3738
workflowpb "go.temporal.io/api/workflow/v1"
@@ -248,6 +249,7 @@ func (b *HistoryBuilder) AddWorkflowTaskCompletedEvent(
248249
startedEventID int64,
249250
identity string,
250251
checksum string,
252+
sdkMetadata *sdkpb.WorkflowTaskCompletedMetadata,
251253
) *historypb.HistoryEvent {
252254
event := b.createNewHistoryEvent(enumspb.EVENT_TYPE_WORKFLOW_TASK_COMPLETED, b.timeSource.Now())
253255
event.Attributes = &historypb.HistoryEvent_WorkflowTaskCompletedEventAttributes{
@@ -256,6 +258,7 @@ func (b *HistoryBuilder) AddWorkflowTaskCompletedEvent(
256258
StartedEventId: startedEventID,
257259
Identity: identity,
258260
BinaryChecksum: checksum,
261+
SdkMetadata: sdkMetadata,
259262
},
260263
}
261264

service/history/workflow/history_builder_test.go

+4
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ import (
3737
enumspb "go.temporal.io/api/enums/v1"
3838
failurepb "go.temporal.io/api/failure/v1"
3939
historypb "go.temporal.io/api/history/v1"
40+
sdkpb "go.temporal.io/api/sdk/v1"
4041
taskqueuepb "go.temporal.io/api/taskqueue/v1"
4142
workflowpb "go.temporal.io/api/workflow/v1"
4243
"go.temporal.io/api/workflowservice/v1"
@@ -667,11 +668,13 @@ func (s *historyBuilderSuite) TestWorkflowTaskCompleted() {
667668
scheduledEventID := rand.Int63()
668669
startedEventID := rand.Int63()
669670
checksum := "random checksum"
671+
metadata := &sdkpb.WorkflowTaskCompletedMetadata{CoreUsedFlags: []uint32{1, 2, 3}, LangUsedFlags: []uint32{4, 5, 6}}
670672
event := s.historyBuilder.AddWorkflowTaskCompletedEvent(
671673
scheduledEventID,
672674
startedEventID,
673675
testIdentity,
674676
checksum,
677+
metadata,
675678
)
676679
s.Equal(event, s.flush())
677680
s.Equal(&historypb.HistoryEvent{
@@ -686,6 +689,7 @@ func (s *historyBuilderSuite) TestWorkflowTaskCompleted() {
686689
StartedEventId: startedEventID,
687690
Identity: testIdentity,
688691
BinaryChecksum: checksum,
692+
SdkMetadata: metadata,
689693
},
690694
},
691695
}, event)

service/history/workflow/workflow_task_state_machine.go

+1
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@ func (m *workflowTaskStateMachine) AddWorkflowTaskCompletedEvent(
539539
workflowTask.StartedEventID,
540540
request.Identity,
541541
request.BinaryChecksum,
542+
request.SdkMetadata,
542543
)
543544

544545
err := m.afterAddWorkflowTaskCompletedEvent(event, maxResetPoints)

0 commit comments

Comments
 (0)