Disable eager activities for Python 0.1a1, 0.1a2, and0.1b1 too (#3793)

bergundy · web-flow · commit ea893d18a112 · 2023-01-09T23:00:31.000-05:00
diff --git a/service/frontend/overrides.go b/service/frontend/overrides.go
@@ -45,7 +45,7 @@ func NewOverrides() *Overrides {
 }
 
 func (o *Overrides) shouldForceDisableEagerDispatch(sdkName, sdkVersion string) bool {
-	if sdkName == headers.ClientNamePythonSDK && sdkVersion == "0.1b2" {
+	if sdkName == headers.ClientNamePythonSDK && (sdkVersion == "0.1a1" || sdkVersion == "0.1a2" || sdkVersion == "0.1b1" || sdkVersion == "0.1b2") {
 		return true
 	} else if sdkName == headers.ClientNameTypeScriptSDK {
 		ver, err := semver.Parse(sdkVersion)
diff --git a/service/frontend/overrides_test.go b/service/frontend/overrides_test.go
@@ -48,8 +48,8 @@ func TestDisableEagerActivityDispatchForBuggyClients(t *testing.T) {
 		{sdkName: headers.ClientNameGoSDK, sdkVersion: "1.18.1", eagerAllowed: true},
 		{sdkName: headers.ClientNameTypeScriptSDK, sdkVersion: "1.4.1", eagerAllowed: false},
 		{sdkName: headers.ClientNameTypeScriptSDK, sdkVersion: "1.4.4", eagerAllowed: true},
+		{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1a1", eagerAllowed: false},
 		{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b2", eagerAllowed: false},
-		{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b1", eagerAllowed: true},
 		{sdkName: headers.ClientNamePythonSDK, sdkVersion: "0.1b3", eagerAllowed: true},
 	}
 	for _, testCase := range cases {

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func NewOverrides() *Overrides {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`func (o *Overrides) shouldForceDisableEagerDispatch(sdkName, sdkVersion string) bool {`
`48`		`- if sdkName == headers.ClientNamePythonSDK && sdkVersion == "0.1b2" {`
	`48`	`+ if sdkName == headers.ClientNamePythonSDK && (sdkVersion == "0.1a1" \|\| sdkVersion == "0.1a2" \|\| sdkVersion == "0.1b1" \|\| sdkVersion == "0.1b2") {`
`49`	`49`	`return true`
`50`	`50`	`} else if sdkName == headers.ClientNameTypeScriptSDK {`
`51`	`51`	`ver, err := semver.Parse(sdkVersion)`