Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless function calls #33

Closed
51-code opened this issue Feb 10, 2025 · 0 comments · Fixed by #34
Closed

Remove useless function calls #33

51-code opened this issue Feb 10, 2025 · 0 comments · Fixed by #34
Assignees
Labels
bug Something isn't working review

Comments

@51-code
Copy link
Contributor

51-code commented Feb 10, 2025

Description

Coverity flagged this line in an equality test for ImmutableMap.java:

immutableMap1.map();

It is marked as useless because the return value is not utilized. The reason for the function call is to check for any side effects from calling it, to ensure immutability in the equality test.

However, equalsverifier is used in the project anyways, so the test is obsolete and can be removed to get rid of the Coverity defect.

@51-code 51-code added the bug Something isn't working label Feb 10, 2025
@51-code 51-code self-assigned this Feb 10, 2025
@51-code 51-code added the review label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant