chore!: Remove legacy WithCreateParameterModifier(Action<CreateContainerParameters>) (#809)

Author: HofmeisterAn

src/Testcontainers/Builders/ContainerBuilder`3.cs

@@ -298,12 +298,6 @@ public TBuilderEntity WithStartupCallback(Func<IContainer, CancellationToken, Ta
       return this.Clone(new ContainerConfiguration(startupCallback: startupCallback));
     }
 
-    /// <inheritdoc cref="IContainerBuilder{TBuilderEntity, TContainerEntity}" />
-    public TBuilderEntity WithCreateContainerParametersModifier(Action<CreateContainerParameters> parameterModifier)
-    {
-      return this.WithCreateParameterModifier(parameterModifier);
-    }
-
     /// <inheritdoc cref="IAbstractBuilder{TBuilderEntity, TResourceEntity, TCreateResourceEntity}" />
     protected override TBuilderEntity Init()
     {

src/Testcontainers/Builders/IContainerBuilder`2.cs

@@ -357,16 +357,5 @@ public interface IContainerBuilder<out TBuilderEntity, out TContainerEntity> : I
     /// <returns>A configured instance of <typeparamref name="TBuilderEntity" />.</returns>
     [PublicAPI]
     TBuilderEntity WithStartupCallback(Func<IContainer, CancellationToken, Task> startupCallback);
-
-    /// <summary>
-    /// Allows low level modifications of <see cref="CreateContainerParameters" /> after the builder configuration has been applied. Multiple low level modifications will be executed in order of insertion.
-    /// </summary>
-    /// <remarks>
-    /// This exposes the underlying Docker.DotNet API. Changes are outside of this project.
-    /// </remarks>
-    /// <param name="parameterModifier">The action that invokes modifying the <see cref="CreateContainerParameters" /> instance.</param>
-    /// <returns>A configured instance of <typeparamref name="TBuilderEntity" />.</returns>
-    [Obsolete("Use WithCreateParameterModifier(Action<CreateContainerParameters>) instead.")]
-    TBuilderEntity WithCreateContainerParametersModifier(Action<CreateContainerParameters> parameterModifier);
   }
 }

tests/Testcontainers.Tests/Unit/Containers/Unix/TestcontainersContainerTest.cs

@@ -461,8 +461,8 @@ public async Task ParameterModifiers()
         var testcontainersBuilder = new TestcontainersBuilder<TestcontainersContainer>()
           .WithImage("alpine")
           .WithEntrypoint(CommonCommands.SleepInfinity)
-          .WithCreateContainerParametersModifier(parameters => parameters.Name = "placeholder")
-          .WithCreateContainerParametersModifier(parameters => parameters.Name = name);
+          .WithCreateParameterModifier(parameters => parameters.Name = "placeholder")
+          .WithCreateParameterModifier(parameters => parameters.Name = name);
 
         // Then
         await using (ITestcontainersContainer testcontainer = testcontainersBuilder.Build())