Skip to content

Commit de410de

Browse files
0xcedHofmeisterAn
andauthored
feat: Change access modifier of OracleBuilder.WithUsername(string) to public (#923)
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
1 parent dd58376 commit de410de

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

src/Testcontainers.Oracle/OracleBuilder.cs

+11-14
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,17 @@ private OracleBuilder(OracleConfiguration resourceConfiguration)
3636
/// <inheritdoc />
3737
protected override OracleConfiguration DockerResourceConfiguration { get; }
3838

39+
/// <summary>
40+
/// Sets the Oracle username.
41+
/// </summary>
42+
/// <param name="username">The Oracle username.</param>
43+
/// <returns>A configured instance of <see cref="OracleBuilder" />.</returns>
44+
public OracleBuilder WithUsername(string username)
45+
{
46+
return Merge(DockerResourceConfiguration, new OracleConfiguration(username: username))
47+
.WithEnvironment("APP_USER", username);
48+
}
49+
3950
/// <summary>
4051
/// Sets the Oracle password.
4152
/// </summary>
@@ -108,20 +119,6 @@ private OracleBuilder WithDatabase(string database)
108119
return Merge(DockerResourceConfiguration, new OracleConfiguration(database: database));
109120
}
110121

111-
/// <summary>
112-
/// Sets the Oracle username.
113-
/// </summary>
114-
/// <remarks>
115-
/// The Docker image does not allow to configure the username.
116-
/// </remarks>
117-
/// <param name="username">The Oracle username.</param>
118-
/// <returns>A configured instance of <see cref="OracleBuilder" />.</returns>
119-
private OracleBuilder WithUsername(string username)
120-
{
121-
return Merge(DockerResourceConfiguration, new OracleConfiguration(username: username))
122-
.WithEnvironment("APP_USER", username);
123-
}
124-
125122
/// <inheritdoc cref="IWaitUntil" />
126123
private sealed class WaitUntil : IWaitUntil
127124
{

0 commit comments

Comments
 (0)