Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: In AzuriteContainer, is there a reason AccountName and AccountKey are not public? #1238

Closed
mcolebiltd opened this issue Aug 24, 2024 · 2 comments · Fixed by #1258
Labels
enhancement New feature or request

Comments

@mcolebiltd
Copy link

Problem

The visiblity of AccountName and AccountKey are private in AzuriteContainer. This makes it difficult to construct a custom connection string if your AzuriteContainer is on a network. MsSqlBuilder makes all relevant info public so we can easily build connection strings.

Solution

I would like to move AccountName and AccountKey to AzuriteBuilder to make it consistent with the MsSqlBuilder, and change the visibility to public.

Furthermore, would there be value in letting the consumer customize these values?

Benefit

Better consistency across modules.

Alternatives

Right now if I was to build a custom connection string, I'd have to hard code the AccountName and AccountKey. This isn't terrible, but it also shouldn't be necessary.

Would you like to help contributing this enhancement?

Yes

@mcolebiltd mcolebiltd added the enhancement New feature or request label Aug 24, 2024
@HofmeisterAn
Copy link
Collaborator

I do not think there is a specific reason why those values are not publicly available. My guess is that they are tied to the image and cannot be changed anyway (no container builder input). But if it helps developers, we could move those properties to the builder and make them public. Would you be interested in contributing and creating a pull request for it?

@mcolebiltd
Copy link
Author

@HofmeisterAn I expect you may be correct about those values being tied directly to the image. I don't see any way to change them in the documentation: https://mcr.microsoft.com/en-us/product/azure-storage/azurite/about

Either way, I still think it would be a good idea to make those public to help us construct the connection strings. I am interested in helping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants