You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The visiblity of AccountName and AccountKey are private in AzuriteContainer. This makes it difficult to construct a custom connection string if your AzuriteContainer is on a network. MsSqlBuilder makes all relevant info public so we can easily build connection strings.
Solution
I would like to move AccountName and AccountKey to AzuriteBuilder to make it consistent with the MsSqlBuilder, and change the visibility to public.
Furthermore, would there be value in letting the consumer customize these values?
Benefit
Better consistency across modules.
Alternatives
Right now if I was to build a custom connection string, I'd have to hard code the AccountName and AccountKey. This isn't terrible, but it also shouldn't be necessary.
Would you like to help contributing this enhancement?
Yes
The text was updated successfully, but these errors were encountered:
I do not think there is a specific reason why those values are not publicly available. My guess is that they are tied to the image and cannot be changed anyway (no container builder input). But if it helps developers, we could move those properties to the builder and make them public. Would you be interested in contributing and creating a pull request for it?
Problem
The visiblity of
AccountName
andAccountKey
are private inAzuriteContainer
. This makes it difficult to construct a custom connection string if your AzuriteContainer is on a network.MsSqlBuilder
makes all relevant info public so we can easily build connection strings.Solution
I would like to move
AccountName
andAccountKey
toAzuriteBuilder
to make it consistent with theMsSqlBuilder
, and change the visibility to public.Furthermore, would there be value in letting the consumer customize these values?
Benefit
Better consistency across modules.
Alternatives
Right now if I was to build a custom connection string, I'd have to hard code the AccountName and AccountKey. This isn't terrible, but it also shouldn't be necessary.
Would you like to help contributing this enhancement?
Yes
The text was updated successfully, but these errors were encountered: