Skip to content

Commit b86cc92

Browse files
committed
fix: Removing GetClient from ChromaContainer
1 parent a24d587 commit b86cc92

File tree

4 files changed

+16
-22
lines changed

4 files changed

+16
-22
lines changed

docs/modules/chroma.md

-8
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,6 @@ This method returns the REST endpoint of the Chroma container, using the default
5959
[Get REST endpoint](../../modules/chroma/chroma_test.go) inside_block:restEndpoint
6060
<!--/codeinclude-->
6161

62-
#### GetClient
63-
64-
This method returns a `chroma-go` client that can be used to interact with the Chroma container.
65-
66-
<!--codeinclude-->
67-
[GetClient](../../modules/chroma/chroma_test.go) inside_block:getClient
68-
<!--/codeinclude-->
69-
7062
## Examples
7163

7264
### Getting a Chroma client

modules/chroma/chroma.go

-10
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import (
44
"context"
55
"fmt"
66

7-
chromago "github.com/amikos-tech/chroma-go"
8-
97
"github.com/testcontainers/testcontainers-go"
108
"github.com/testcontainers/testcontainers-go/wait"
119
)
@@ -60,11 +58,3 @@ func (c *ChromaContainer) RESTEndpoint(ctx context.Context) (string, error) {
6058

6159
return fmt.Sprintf("http://%s:%s", host, containerPort.Port()), nil
6260
}
63-
64-
func (c *ChromaContainer) GetClient(opt ...chromago.ClientOption) (*chromago.Client, error) {
65-
endpoint, err := c.RESTEndpoint(context.Background())
66-
if err != nil {
67-
return nil, err
68-
}
69-
return chromago.NewClient(endpoint, opt...)
70-
}

modules/chroma/chroma_test.go

+6-2
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,14 @@ func TestChroma(t *testing.T) {
4949

5050
t.Run("GetClient", func(tt *testing.T) {
5151
// restEndpoint {
52-
chromaClient, err := container.GetClient(chromago.WithDebug(true))
52+
endpoint, err := container.RESTEndpoint(context.Background())
53+
if err != nil {
54+
tt.Fatalf("failed to get REST endpoint: %s", err) // nolint:gocritic
55+
}
56+
chromaClient, err := chromago.NewClient(endpoint)
5357
// }
5458
if err != nil {
55-
tt.Fatalf("failed to get REST endpoint: %s", err)
59+
tt.Fatalf("failed to create client: %s", err)
5660
}
5761

5862
hb, err := chromaClient.Heartbeat(context.TODO())

modules/chroma/examples_test.go

+10-2
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,11 @@ func ExampleChromaContainer_connectWithClient() {
5656
}
5757
}()
5858

59-
chromaClient, err := chromaContainer.GetClient()
59+
endpoint, err := chromaContainer.RESTEndpoint(context.Background())
60+
if err != nil {
61+
log.Fatalf("failed to get REST endpoint: %s", err) // nolint:gocritic
62+
}
63+
chromaClient, err := chromago.NewClient(endpoint)
6064
if err != nil {
6165
log.Fatalf("failed to get client: %s", err) // nolint:gocritic
6266
}
@@ -90,7 +94,11 @@ func ExampleChromaContainer_collections() {
9094

9195
// getClient {
9296
// create the client connection and confirm that we can access the server with it
93-
chromaClient, err := chromaContainer.GetClient(chromago.WithDebug(true))
97+
endpoint, err := chromaContainer.RESTEndpoint(context.Background())
98+
if err != nil {
99+
log.Fatalf("failed to get REST endpoint: %s", err) // nolint:gocritic
100+
}
101+
chromaClient, err := chromago.NewClient(endpoint)
94102
// }
95103
if err != nil {
96104
log.Fatalf("failed to get client: %s", err) // nolint:gocritic

0 commit comments

Comments
 (0)