Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: reuse und checks cannot be configured via classpath:testcontainers.properties #8060

Closed
axelfontaine opened this issue Jan 8, 2024 · 1 comment
Labels

Comments

@axelfontaine
Copy link

Module

Core

Testcontainers version

1.19.3

Using the latest Testcontainers version?

Yes

Host OS

Windows

Host Arch

x64

Docker version

n/a

What happened?

Placing a testcontainers.properties file at the root of the classpath should allow configuration of testcontainers.

For testcontainers.reuse.enabled and checks.disable this is not possible as these properties are checked using getEnvVarOrUserProperty (which ignores classpathProperties) instead of getEnvVarOrProperty.

Source code references:

Relevant log output

No response

Additional Information

No response

@kiview
Copy link
Member

kiview commented Jul 11, 2024

Thanks for raising this issue, but this works as intended for these properties, since we believe this should be a user decision, and not a project decision.

@kiview kiview closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants