Skip to content

Commit c680d1c

Browse files
committed
switch away from deno's language server
As documented in denoland/deno#2506, deno refuses to import modules without a file extension, which means goto-definition doesn't work in typescript, which is the point of the language server, so we're switching back to node despite the inferior functionality.
1 parent 7e3310f commit c680d1c

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

Makefile

+8-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,14 @@ install-dependencies: install-lsp-servers
4444

4545
install-lsp-servers:
4646
npm i -g bash-language-server
47-
curl -fsSL https://deno.land/install.sh | sh
48-
npm i -g @angular/language-service@next @angular/language-server
47+
# Typescript does not allow file extensions in imports, but for some reason deno insists that they
48+
# must exist, and then just ignores the error and makes its own. I can't understand why they made
49+
# this decision, but it appears firm. I'm keeping this line commented out in the hopes that deno
50+
# will release an update in the future which either fixes this or introduces a typescript
51+
# compatibility mode. For now we'll use the node language server. See
52+
# https://github.com/denoland/deno/issues/2506 for more discussion.
53+
# curl -fsSL https://deno.land/install.sh | sh
54+
npm i -g @angular/language-service@next typescript @angular/language-server typescript-language-server
4955
pip3 install python-lsp-server pyls-mypy black pyls-black pyls-isort flake8 jedi
5056
pip3 install "ptvsd>=4.2"
5157
rustup component add rls rust-analysis rust-src

0 commit comments

Comments
 (0)