Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hound/Rubocop Config #224

Open
joe-sharp opened this issue Mar 2, 2024 · 5 comments
Open

Hound/Rubocop Config #224

joe-sharp opened this issue Mar 2, 2024 · 5 comments

Comments

@joe-sharp
Copy link
Contributor

Any chance you can check-in the Rubocop config? The rules that Hound enforces are a bit difficult to predict. If Hound is using its own default config may I suggest going with something closer to what Rubocop uses for defaults? Happy to update the codebase to adhere to the rules as well. Thanks for considering it!

@nickcharlton
Copy link
Member

It comes from our guides repo.

I'd like to switch over to standard, which is what we've done everywhere else at some point.

@n-rodriguez
Copy link
Contributor

Hi there! Any news?

@pboling
Copy link
Contributor

pboling commented Feb 25, 2025

#250 switches to rubocop-lts, which is a wrapper around rubocop, standard, and rubocop-gradual (an Evil Martians project). rubocop-lts has a discrete major version customized for every specific minor release of Ruby.

Hound is entirely incompatible with the setup, and suggests making many changes that would result in syntax errors in the code.

  • Turn off Hound, or restrict to very basic comments, like "line too long"
  • Add style workflow #251 As an alternative, I'll be adding a Style workflow which will enforce style directly in CI.

@nickcharlton
Copy link
Member

I'm expecting to have to turn off Hound. I haven't looked at this in a while, but I'd not be against just switching to entire style to follow standard in one go. It's what I did with Administrate: thoughtbot/administrate#2508

@pboling
Copy link
Contributor

pboling commented Feb 28, 2025

My hope is you'll find that going one step further than standard carries many benefits.

I'll setup the style workflow so you can see... but hound will continue to be annoying as hell, and it'll be in a branch off of the same #250 that fixes the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants