Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to rand 0.8 #298

Closed
dmit opened this issue Dec 19, 2020 · 0 comments · Fixed by #304
Closed

Upgrading to rand 0.8 #298

dmit opened this issue Dec 19, 2020 · 0 comments · Fixed by #304
Labels
A-third-party Area: implementations of traits from other crates
Milestone

Comments

@dmit
Copy link
Contributor

dmit commented Dec 19, 2020

A new version of the rand crate has been released. While the changes needed to upgrade time itself are trivial, quickcheck still depends on rand 0.7.3 and it is unclear when a new version will be released (although there's already a PR at BurntSushi/quickcheck#264).

It is technically possible to rely on both 0.7.3 (for quickcheck) and 0.8.0 (for everything else) by doing something like this:

[dependencies]
rand = { version = "0.8.0", optional = true, default-features = false }
rand-07 = { package = "rand", version = "0.7.3", optional = true, default-features = false }

[features]
quickcheck = ["quickcheck-dep", "rand-07", "std"]

Although it's not very pretty. I'll submit a PR to give a better idea of what the changes look like.

MSRV is not affected, since rand 0.8 supports Rust >=1.36.

@jhpratt jhpratt added the A-third-party Area: implementations of traits from other crates label Dec 21, 2020
@jhpratt jhpratt added this to the v0.3 milestone Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-third-party Area: implementations of traits from other crates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants