Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io::driver should have loom tests #3018

Open
bdonlan opened this issue Oct 21, 2020 · 0 comments
Open

io::driver should have loom tests #3018

bdonlan opened this issue Oct 21, 2020 · 0 comments
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. E-help-wanted Call for participation: Help is requested to fix this issue. M-io Module: tokio/io M-runtime Module: tokio/runtime

Comments

@bdonlan
Copy link
Contributor

bdonlan commented Oct 21, 2020

There are some bugs such as #2924 that would be much easier to test with loom testing. This will however require some internal refactoring and mocking to isolate the IO driver from mio and the underlying OS.
@bdonlan bdonlan added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate labels Oct 21, 2020
@Darksonn Darksonn added M-io Module: tokio/io M-runtime Module: tokio/runtime labels Oct 21, 2020
@carllerche carllerche added the E-help-wanted Call for participation: Help is requested to fix this issue. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. E-help-wanted Call for participation: Help is requested to fix this issue. M-io Module: tokio/io M-runtime Module: tokio/runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carllerche @bdonlan @Darksonn