Bugfix version 1.4.4.2; avoid corrupting large texts

Thanks to a bug reported via email, I was able to track down the issue
to some subtly incorrect code where `bits`, a char, was used like an int
and more than 16 bits are assigned to it (this truncates the upper
bits). This only happened if `dictionary`, an ArrayList of String
containing repeated segments of text to compress, exceeded a size of
65536, which never happened on the small sample data. The fix was simple
(use an int instead of reusing a char where a char isn't applicable),
and now version 1.4.4.2 is out. This bug doesn't appear to affect the
original lz-string library for JS by pieroxy, but probably could affect
lz-string4java by rufushuang , unless it's been fixed already there or
my changes introduced the bug.

Author: tommyettinger

demo/TransmissionDemo/core/src/main/java/blazing/chain/demo/TransmissionDemo.java

@@ -14,8 +14,7 @@
 import com.kotcrab.vis.ui.widget.VisTextArea;
 import com.kotcrab.vis.ui.widget.VisTextButton;
 
-import static blazing.chain.LZSEncoding.compressToEncodedURIComponent;
-import static blazing.chain.LZSEncoding.decompressFromEncodedURIComponent;
+import static blazing.chain.LZSEncoding.*;
 
 /**
  * {@link com.badlogic.gdx.ApplicationListener} implementation shared by all platforms.
@@ -47,8 +46,10 @@ public void create() {
         preferences = Gdx.app.getPreferences("blazingchain");
         currentText = preferences.getString("normal", "");
         compressedText = preferences.getString("compressed", "");
-        if(currentText == null || currentText.isEmpty()) currentText = mars;
-        if(compressedText == null || compressedText.isEmpty()) compressedText = compressToEncodedURIComponent(currentText);
+        if(currentText == null || currentText.isEmpty()) 
+            currentText = mars;
+        if(compressedText == null || compressedText.isEmpty())
+            compressedText = compressToBase64(currentText);
         stage = new Stage(new ScreenViewport());
 
         VisTable root = new VisTable();
@@ -72,7 +73,7 @@ public void create() {
         compressButton.addListener(new ChangeListener() {
             @Override
             public void changed(ChangeEvent event, Actor actor) {
-                compressedText = compressToEncodedURIComponent(currentText = currentArea.getText());
+                compressedText = compressToBase64(currentText = currentArea.getText());
                 compressedArea.setText(compressedText);
                 preferences.putString("normal", currentText);
                 preferences.putString("compressed", compressedText);
@@ -92,7 +93,7 @@ public void changed(ChangeEvent event, Actor actor) {
         decompressButton.addListener(new ChangeListener() {
             @Override
             public void changed(ChangeEvent event, Actor actor) {
-                currentText = decompressFromEncodedURIComponent(compressedText = compressedArea.getText());
+                currentText = decompressFromBase64(compressedText = compressedArea.getText());
                 currentArea.setText(currentText);
                 preferences.putString("normal", currentText);
                 preferences.putString("compressed", compressedText);

demo/TransmissionDemo/gradle.properties

@@ -4,7 +4,7 @@ org.gradle.configureondemand=true
 #squidlibVersion=ddcbc5c33d
 #squidlibVersion=3.0.0-SNAPSHOT
 visUiVersion=1.2.1
-blazingchainVersion=1.4.4.1
+blazingchainVersion=1.4.4.2
 gwtFrameworkVersion=2.8.0
 gwtPluginVersion=0.6
 androidPluginVersion=2.2.0

demo/TransmissionDemo/gwt/src/main/java/blazing/chain/demo/gwt/GwtTransmissionDemo.java

@@ -9,8 +9,8 @@
 import com.google.gwt.user.client.Event;
 import com.google.gwt.user.client.ui.*;
 
-import static blazing.chain.LZSEncoding.compressToEncodedURIComponent;
-import static blazing.chain.LZSEncoding.decompressFromEncodedURIComponent;
+import static blazing.chain.LZSEncoding.compressToBase64;
+import static blazing.chain.LZSEncoding.decompressFromBase64;
 
 /**
  * Transmission app in pure GWT so users can copy/paste in and out of it.
@@ -43,7 +43,7 @@ public void start()
         currentText = preferences.getString("normal", "");
         compressedText = preferences.getString("compressed", "");
         if(currentText == null || currentText.isEmpty()) currentText = mars;
-        if(compressedText == null || compressedText.isEmpty()) compressedText = compressToEncodedURIComponent(currentText);
+        if(compressedText == null || compressedText.isEmpty()) compressedText = compressToBase64(currentText);
 
         currentArea = new TextArea();
         currentArea.setText(currentText);
@@ -71,7 +71,7 @@ public void start()
         compressButton.addClickHandler(new ClickHandler() {
             @Override
             public void onClick(ClickEvent event) {
-                compressedText = compressToEncodedURIComponent(currentText = currentArea.getText());
+                compressedText = compressToBase64(currentText = currentArea.getText());
                 compressedArea.setText(compressedText);
                 preferences.putString("normal", currentText);
                 preferences.putString("compressed", compressedText);
@@ -86,7 +86,7 @@ public void onClick(ClickEvent event) {
         decompressButton.addClickHandler(new ClickHandler() {
             @Override
             public void onClick(ClickEvent event) {
-                currentText = decompressFromEncodedURIComponent(compressedText = compressedArea.getText());
+                currentText = decompressFromBase64(compressedText = compressedArea.getText());
                 currentArea.setText(currentText);
                 preferences.putString("normal", currentText);
                 preferences.putString("compressed", compressedText);

docs/html/28D8E3A8455A7BF81F2E1AC1FFBB320B.cache.js

@@ -1,16 +1,16 @@
-48503BC226755E18BDF240A9AF0861D8.cache.js
-user.agent gecko1_8
-
-6E514421552A38A546948B81EF26F89B.cache.js
+28D8E3A8455A7BF81F2E1AC1FFBB320B.cache.js
 user.agent ie10
 
-7E04484EC133E74B71E10D5176ECA166.cache.js
-user.agent ie9
+35C243AF5964E5B1B182EA3DE089577F.cache.js
+user.agent ie8
 
-C353746B832E409742A0D51EB1B564CA.cache.js
+480185803EB4379D029CB4CC7332840D.cache.js
+user.agent gecko1_8
+
+4F12116759E1C1A02D5A2ED3BD34572C.cache.js
 user.agent safari
 
-F04E1FB880B442FAB07E789CC537BB62.cache.js
-user.agent ie8
+8C49BAC3A312BB1EE7B504649EE71B78.cache.js
+user.agent ie9
 
 Devmode:devmode.js

docs/html/35C243AF5964E5B1B182EA3DE089577F.cache.js

@@ -6,7 +6,7 @@
 
     <groupId>com.github.tommyettinger</groupId>
     <artifactId>blazingchain</artifactId>
-    <version>1.4.4.1</version>
+    <version>1.4.4.2</version>
     <description>LZ-String encoding for Java; cross-platform to desktop, GWT, and Android at the minimum.
     </description>
     <name>BlazingChain</name>

docs/html/480185803EB4379D029CB4CC7332840D.cache.js

@@ -1,9 +1,9 @@
 /*
- * LZString4Java By Rufus Huang 
+ * LZString4Java By Rufus Huang
  * https://github.com/rufushuang/lz-string4java
  * MIT License
- * 
- * Port from original JavaScript version by pieroxy 
+ *
+ * Port from original JavaScript version by pieroxy
  * https://github.com/pieroxy/lz-string
  */
 
@@ -409,8 +409,7 @@ private static String _decompress(int length, int resetValue, char[] getNextValu
             if (index > length) {
                 return "";
             }
-
-            bits = 0;
+            int cc = 0;
             maxpower = numBits;
             power = 0;
             while (power != maxpower) {
@@ -420,10 +419,9 @@ private static String _decompress(int length, int resetValue, char[] getNextValu
                     position = resetValue;
                     val = (modify == null) ? (char) (getNextValue[index++] + offset) : modify[getNextValue[index++]];
                 }
-                bits |= (resb > 0 ? 1 : 0) << power++;
+                cc |= (resb > 0 ? 1 : 0) << power++;
             }
-            int cc;
-            switch (cc = bits) {
+            switch (cc) {
                 case 0:
                     bits = 0;
                     maxpower = 8;