Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcards in ignored_containers #653

Closed
mortenlj opened this issue Jan 22, 2024 · 1 comment · Fixed by #666
Closed

Support wildcards in ignored_containers #653

mortenlj opened this issue Jan 22, 2024 · 1 comment · Fixed by #666
Labels
C-feature request New feature request

Comments

@mortenlj
Copy link

When ignoring containers to pull, it would be useful to be able to use wildcards.

When you use docker for development, you often end up with loads of locally built images with various tags.
These will never be possible to pull, and you wouldn't want to either, because they represent your local state.

While the new feature in v14 allows ignoring specific image tags, often it would be more effective to ignore large sets using wildcards. That way the image would be ignored even if I decide to tag it with a slug describing the current branch or time of day.

More information

I'm not sure how I would test a side branch of topgrade, but I might be able to work on a PR.

If I were to tackle it, I think I would base the approach on Globset, where the values in the config are interpreted as globs instead of doing equality matching. It would be backwards compatible with any currently configured values.

@SteveLauC
Copy link
Member

Implemented in #666, cc folks who are also interested in this @CharlesChiuGit @dannysteenman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants