Skip to content

Commit 0b46b8a

Browse files
Sonny Raoolofj
Sonny Rao
authored andcommitted
clocksource: arch_timer: Fix code to use physical timers when requested
This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores the arch_counter_get_cntpct() function after removal in 0d651e4 "clocksource: arch_timer: use virtual counters" We need this on certain ARMv7 systems which are architected like this: * The firmware doesn't know and doesn't care about hypervisor mode and we don't want to add the complexity of hypervisor there. * The firmware isn't involved in SMP bringup or resume. * The ARCH timer come up with an uninitialized offset between the virtual and physical counters. Each core gets a different random offset. * The device boots in "Secure SVC" mode. * Nothing has touched the reset value of CNTHCTL.PL1PCEN or CNTHCTL.PL1PCTEN (both default to 1 at reset) One example of such as system is RK3288 where it is much simpler to use the physical counter since there's nobody managing the offset and each time a core goes down and comes back up it will get reinitialized to some other random value. Fixes: 0d651e4 ("clocksource: arch_timer: use virtual counters") Cc: stable@vger.kernel.org Signed-off-by: Sonny Rao <sonnyrao@chromium.org> Acked-by: Catalin Marinas <catalin.marinas@arm.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Olof Johansson <olof@lixom.net>
1 parent f114040 commit 0b46b8a

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

arch/arm/include/asm/arch_timer.h

+9
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,15 @@ static inline u32 arch_timer_get_cntfrq(void)
7878
return val;
7979
}
8080

81+
static inline u64 arch_counter_get_cntpct(void)
82+
{
83+
u64 cval;
84+
85+
isb();
86+
asm volatile("mrrc p15, 0, %Q0, %R0, c14" : "=r" (cval));
87+
return cval;
88+
}
89+
8190
static inline u64 arch_counter_get_cntvct(void)
8291
{
8392
u64 cval;

arch/arm64/include/asm/arch_timer.h

+9
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,15 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
104104
asm volatile("msr cntkctl_el1, %0" : : "r" (cntkctl));
105105
}
106106

107+
static inline u64 arch_counter_get_cntpct(void)
108+
{
109+
/*
110+
* AArch64 kernel and user space mandate the use of CNTVCT.
111+
*/
112+
BUG();
113+
return 0;
114+
}
115+
107116
static inline u64 arch_counter_get_cntvct(void)
108117
{
109118
u64 cval;

drivers/clocksource/arm_arch_timer.c

+4-1
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,10 @@ static void __init arch_counter_register(unsigned type)
462462

463463
/* Register the CP15 based counter if we have one */
464464
if (type & ARCH_CP15_TIMER) {
465-
arch_timer_read_counter = arch_counter_get_cntvct;
465+
if (arch_timer_use_virtual)
466+
arch_timer_read_counter = arch_counter_get_cntvct;
467+
else
468+
arch_timer_read_counter = arch_counter_get_cntpct;
466469
} else {
467470
arch_timer_read_counter = arch_counter_get_cntvct_mem;
468471

0 commit comments

Comments
 (0)