Skip to content

Commit a14a2d4

Browse files
committed
powerpc: cpm_common: use gpiochip data pointer
This makes the driver use the data pointer added to the gpio_chip to store a pointer to the state container instead of relying on container_of(). Cc: Anatolij Gustschin <agust@denx.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent e65078f commit a14a2d4

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

arch/powerpc/sysdev/cpm_common.c

+6-12
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,9 @@ struct cpm2_gpio32_chip {
8080
u32 cpdata;
8181
};
8282

83-
static inline struct cpm2_gpio32_chip *
84-
to_cpm2_gpio32_chip(struct of_mm_gpio_chip *mm_gc)
85-
{
86-
return container_of(mm_gc, struct cpm2_gpio32_chip, mm_gc);
87-
}
88-
8983
static void cpm2_gpio32_save_regs(struct of_mm_gpio_chip *mm_gc)
9084
{
91-
struct cpm2_gpio32_chip *cpm2_gc = to_cpm2_gpio32_chip(mm_gc);
85+
struct cpm2_gpio32_chip *cpm2_gc = gpiochip_get_data(&mm_gc->gc);
9286
struct cpm2_ioports __iomem *iop = mm_gc->regs;
9387

9488
cpm2_gc->cpdata = in_be32(&iop->dat);
@@ -108,7 +102,7 @@ static int cpm2_gpio32_get(struct gpio_chip *gc, unsigned int gpio)
108102
static void __cpm2_gpio32_set(struct of_mm_gpio_chip *mm_gc, u32 pin_mask,
109103
int value)
110104
{
111-
struct cpm2_gpio32_chip *cpm2_gc = to_cpm2_gpio32_chip(mm_gc);
105+
struct cpm2_gpio32_chip *cpm2_gc = gpiochip_get_data(&mm_gc->gc);
112106
struct cpm2_ioports __iomem *iop = mm_gc->regs;
113107

114108
if (value)
@@ -122,7 +116,7 @@ static void __cpm2_gpio32_set(struct of_mm_gpio_chip *mm_gc, u32 pin_mask,
122116
static void cpm2_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int value)
123117
{
124118
struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
125-
struct cpm2_gpio32_chip *cpm2_gc = to_cpm2_gpio32_chip(mm_gc);
119+
struct cpm2_gpio32_chip *cpm2_gc = gpiochip_get_data(gc);
126120
unsigned long flags;
127121
u32 pin_mask = 1 << (31 - gpio);
128122

@@ -136,7 +130,7 @@ static void cpm2_gpio32_set(struct gpio_chip *gc, unsigned int gpio, int value)
136130
static int cpm2_gpio32_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
137131
{
138132
struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
139-
struct cpm2_gpio32_chip *cpm2_gc = to_cpm2_gpio32_chip(mm_gc);
133+
struct cpm2_gpio32_chip *cpm2_gc = gpiochip_get_data(gc);
140134
struct cpm2_ioports __iomem *iop = mm_gc->regs;
141135
unsigned long flags;
142136
u32 pin_mask = 1 << (31 - gpio);
@@ -154,7 +148,7 @@ static int cpm2_gpio32_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
154148
static int cpm2_gpio32_dir_in(struct gpio_chip *gc, unsigned int gpio)
155149
{
156150
struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
157-
struct cpm2_gpio32_chip *cpm2_gc = to_cpm2_gpio32_chip(mm_gc);
151+
struct cpm2_gpio32_chip *cpm2_gc = gpiochip_get_data(gc);
158152
struct cpm2_ioports __iomem *iop = mm_gc->regs;
159153
unsigned long flags;
160154
u32 pin_mask = 1 << (31 - gpio);
@@ -190,6 +184,6 @@ int cpm2_gpiochip_add32(struct device_node *np)
190184
gc->get = cpm2_gpio32_get;
191185
gc->set = cpm2_gpio32_set;
192186

193-
return of_mm_gpiochip_add(np, mm_gc);
187+
return of_mm_gpiochip_add_data(np, mm_gc, cpm2_gc);
194188
}
195189
#endif /* CONFIG_CPM2 || CONFIG_8xx_GPIO */

0 commit comments

Comments
 (0)